[squidsk]

Originally Posted by nerbert

Here's the offending code :

		if (!$vbulletin->GPC['advanced'])
		{
			if ($vbulletin->GPC_exists['emailupdate'])
			{
				$edit['emailupdate'] =& $vbulletin->GPC['emailupdate'];
			}
			else
			{
				$edit['emailupdate'] = array_pop($array = array_keys(fetch_emailchecked($threadinfo)));
			}
			if ($vbulletin->GPC_exists['htmlstate'] AND $foruminfo['allowhtml'])
			{
				$edit['htmlstate'] = array_pop($array = array_keys(fetch_htmlchecked($vbulletin->GPC['htmlstate'])));
			}
		}

It looks obvious to me that you should simply edit out "$array = ". Tried that but it didn't get rid of the warning. Does anyone know what the problem is with that line?

You need to pull out the $array = . . . onto its own line and then pass $array into the function that will clear the error.

Note: You'll have to do that for the if statement as well. This is a php conflict with vb, not sure if that one is on the list of conflicts fixed in 4.2.3 or not.

		if (!$vbulletin->GPC['advanced'])
		{
			if ($vbulletin->GPC_exists['emailupdate'])
			{
				$edit['emailupdate'] =& $vbulletin->GPC['emailupdate'];
			}
			else
			{
				$array = array_keys(fetch_emailchecked($threadinfo));
				$edit['emailupdate'] = array_pop($array);
			}
			if ($vbulletin->GPC_exists['htmlstate'] AND $foruminfo['allowhtml'])
			{
				$edit['htmlstate'] = array_pop($array = array_keys(fetch_htmlchecked($vbulletin->GPC['htmlstate'])));
			}
		}