Thread: Add-On Releases - vBSSO - vBulletin Single Sign-On
View Single Post
  #896  
Old 01-19-2015, 07:07 AM
xeagle xeagle is offline
 
Join Date: Sep 2011
Posts: 477
Благодарил(а): 0 раз(а)
Поблагодарили: 0 раз(а) в 0 сообщениях
Default

Quote:
Originally Posted by TiKu View Post
We use vBSSO to connect vBulletin 4.2 with Wordpress 4.0 and Mediawiki 1.23. One of our users has the vBulletin user name "T?sti's Welle". I don't know whether Wordpress can deal with this user name, as the user is not in a user group that has access to our Wordpress dashboard. But Mediawiki has problems with this name - the user does not get logged in to Mediawiki. And worse: According to the vBSSO logs the system runs into a SQL error, that seems to occur due to missing escaping of the apostroph in the user name. This seems like a security hole to me, as it might allow SQL injection!
Here are the important lines from the log file (I've removed some parts to protect our forum):
Code:
Sun Jan 18 19:08:18 2015,584 [23526] DEBUG localFileLogger - Platform request JSON: {"email":"xyz@mydomain.com","username":"T\u00e4sti's Welle","usergroup":"2","e":6,"lid":"547a124e343fb2.23578572","d":"http:\/\/www.mydomain.com\/vbulletin\/admincp\/user.php?do=edit&u=98985"}
Sun Jan 18 19:08:18 2015,584 [23526] DEBUG localFileLogger - Platform request encrypted JSON: HHqgd6uMZZyW2mJIZ63QhGgJPoi//Gm4a1+Fp5a/49YTXbCsUhbeidQWpRqhfaQqfixmAr/iG1lKUJZfMLV85UKZdCgG94Wm5TuI9tqYzsMLBy2wqqVcSRd8ErbXB314PF4bhT11cXpNp3X9lrp8fSNHA++0SvzZZMfrhKwF+fwFVgXMOhcLohxTQ0tFzuLUazAIPVFU0dsRMlhRVr2YRfH8pOZcL24kDCFAyzU7pNc58c5AKoS7E1DCFm7Gah19kRXadS1yT4MoXhHOqKCE9Q==
Sun Jan 18 19:08:18 2015,584 [23526] DEBUG localFileLogger - Platform request urlencoded/encrypted JSON: HHqgd6uMZZyW2mJIZ63QhGgJPoi%2F%2FGm4a1%2BFp5a%2F49YTXbCsUhbeidQWpRqhfaQqfixmAr%2FiG1lKUJZfMLV85UKZdCgG94Wm5TuI9tqYzsMLBy2wqqVcSRd8ErbXB314PF4bhT11cXpNp3X9lrp8fSNHA%2B%2B0SvzZZMfrhKwF%2BfwFVgXMOhcLohxTQ0tFzuLUazAIPVFU0dsRMlhRVr2YRfH8pOZcL24kDCFAyzU7pNc58c5AKoS7E1DCFm7Gah19kRXadS1yT4MoXhHOqKCE9Q%3D%3D
Sun Jan 18 19:08:18 2015,642 [23526] DEBUG localFileLogger - Communication: Platform returned http status code: 200
Sun Jan 18 19:08:18 2015,642 [23526] DEBUG localFileLogger - Communication: Platform returned error: 
Sun Jan 18 19:08:18 2015,642 [23526] DEBUG localFileLogger - Communication: Platform returned response: <!DOCTYPE HTML>
<html>
<head>
	<title>MediaWiki API</title>
</head>
<body>
<pre>
<span style="color:blue;">&lt;?xml version=&quot;1.0&quot;?&gt;</span>
<span style="color:blue;">&lt;api&gt;</span>
  <span style="color:blue;">&lt;error code=&quot;internal_api_error_DBQueryError&quot; info=&quot;Database query error&quot; xml:space=&quot;preserve&quot;&gt;</span>

#0 /apache/dc/htdocs/wiki/includes/db/Database.php(1123): DatabaseBase-&gt;reportQueryError('Table './dcwiki...', 145, 'INSERT IGNORE I...', 'User::removeGro...', false)
#1 /apache/dc/htdocs/wiki/includes/db/Database.php(1920): DatabaseBase-&gt;query('INSERT IGNORE I...', 'User::removeGro...')
#2 /apache/dc/htdocs/wiki/includes/User.php(2968): DatabaseBase-&gt;insert('user_former_gro...', Array, 'User::removeGro...', Array)
#3 /apache/dc/htdocs/wiki/extensions/vbsso/includes/api.php(63): User-&gt;removeGroup('bot')
#4 [internal function]: vbsso_listener_register(Array)
#5 /apache/dc/htdocs/wiki/extensions/vbsso/includes/sharedapi.php(349): call_user_func('vbsso_listener_...', Array)
#6 /apache/dc/htdocs/wiki/extensions/vbsso/apivbsso.php(35): sharedapi_data_handler(9, '1.23.5', '1.0.1', '316050855963126...', Array)
#7 /apache/dc/htdocs/wiki/includes/api/ApiMain.php(913): vbsso-&gt;execute()
#8 /apache/dc/htdocs/wiki/includes/api/ApiMain.php(363): ApiMain-&gt;executeAction()
#9 /apache/dc/htdocs/wiki/includes/api/ApiMain.php(334): ApiMain-&gt;executeActionWithErrorHandling()
#10 /apache/dc/htdocs/wiki/api.php(85): ApiMain-&gt;execute()
#11 {main}

<span style="color:blue;">&lt;/error&gt;</span>
<span style="color:blue;">&lt;/api&gt;</span>
</pre>
</body>
</html>
<script>if(window.mw){
mw.config.set({"wgBackendResponseTime":54});
}</script>
Sun Jan 18 19:08:18 2015,642 [23526] ERROR localFileLogger - Communication: Unable to accept response:
Sun Jan 18 19:08:18 2015,642 [23526] ERROR localFileLogger - Wrong Shared Password
There is another user with the same problem, but another kind of apostroph in his name (? instead of ').

So if this is a vulnerability, can it please be fixed?
Is there a way that vBSSO converts user names on the fly so that Mediawiki will accept them? For instance any apostroph could be removed or replaced with a dash, followed by the apostroph's hex code.

Regards
TiKu
Could you please contact support team http://vbsso.com/report-an-issue/ describing the steps you use to reproduce your case on your website.

Thank you,
Reply With Quote
 
X vBulletin 3.8.12 by vBS Debug Information
  • Page Generation 0.01021 seconds
  • Memory Usage 1,793KB
  • Queries Executed 11 (?)
More Information
Template Usage:
  • (1)SHOWTHREAD_SHOWPOST
  • (1)ad_footer_end
  • (1)ad_footer_start
  • (1)ad_header_end
  • (1)ad_header_logo
  • (1)ad_navbar_below
  • (1)bbcode_code
  • (1)bbcode_quote
  • (1)footer
  • (1)gobutton
  • (1)header
  • (1)headinclude
  • (6)option
  • (1)post_thanks_box
  • (1)post_thanks_button
  • (1)post_thanks_javascript
  • (1)post_thanks_navbar_search
  • (1)post_thanks_postbit_info
  • (1)postbit
  • (1)postbit_onlinestatus
  • (1)postbit_wrapper
  • (1)spacer_close
  • (1)spacer_open 

Phrase Groups Available:
  • global
  • postbit
  • reputationlevel
  • showthread
Included Files:
  • ./showpost.php
  • ./global.php
  • ./includes/init.php
  • ./includes/class_core.php
  • ./includes/config.php
  • ./includes/functions.php
  • ./includes/class_hook.php
  • ./includes/modsystem_functions.php
  • ./includes/functions_bigthree.php
  • ./includes/class_postbit.php
  • ./includes/class_bbcode.php
  • ./includes/functions_reputation.php
  • ./includes/functions_post_thanks.php 

Hooks Called:
  • init_startup
  • init_startup_session_setup_start
  • init_startup_session_setup_complete
  • cache_permissions
  • fetch_postinfo_query
  • fetch_postinfo
  • fetch_threadinfo_query
  • fetch_threadinfo
  • fetch_foruminfo
  • style_fetch
  • cache_templates
  • global_start
  • parse_templates
  • global_setup_complete
  • showpost_start
  • bbcode_fetch_tags
  • bbcode_create
  • postbit_factory
  • showpost_post
  • postbit_display_start
  • post_thanks_function_post_thanks_off_start
  • post_thanks_function_post_thanks_off_end
  • post_thanks_function_fetch_thanks_start
  • post_thanks_function_fetch_thanks_end
  • post_thanks_function_thanked_already_start
  • post_thanks_function_thanked_already_end
  • fetch_musername
  • postbit_imicons
  • bbcode_parse_start
  • bbcode_parse_complete_precache
  • bbcode_parse_complete
  • postbit_display_complete
  • post_thanks_function_can_thank_this_post_start
  • showpost_complete