View Single Post
  #2261  
Old 08-27-2014, 12:20 PM
findingpeace's Avatar
findingpeace findingpeace is offline
 
Join Date: Nov 2011
Posts: 268
Благодарил(а): 0 раз(а)
Поблагодарили: 0 раз(а) в 0 сообщениях
Default

I love this mod, but it takes a toll on my site's performance.

All other DBTech mods are so good with caching and speed, so I decided to investigate what's up with this one specifically. I found the culprit to be the following hook:

Global Initialisation in global_bootstrap_init_complete

Which calls this file:

/dbtech/thanks/hooks/global_start.php

Which in turn calls /dbtech/thanks/includes/class_core.php (for THANKS::init($vbulletin))

In class_core.php, under the function public static function init($vbulletin), if I comment out the following line:

Code:
self::_getPermissions();
And test my website, page load times drop .1 - .3 seconds, consistently. This may not seem like a lot, but under heavy load, it makes a huge difference.

Because this is a global hook, it causes slowness across the entire website, even pages that don't have any Thanks / Likes logic on them.

Of course, I can't actually leave this line commented out because I'm sure it's important.

So I would ask if there's anything we can do to optimize this, considering it's global?

I also have User Tagging installed, and I tested the same with that. The Global Initialisation for that has no impact on performance. I can disable the entire mod and the site is the same speed. the getPermissions function is identical to the Thanks / Likes getPermissions function.

So what specifically about Global Initialisation and getPermissions for Thanks / Likes is slowing things down?

Note: This testing was done on my QA environment, which is 100% vanilla vBulletin 4.2.2 with no other mods installed.

Thanks!
Reply With Quote
Благодарность от:
Taringa! CS
 
X vBulletin 3.8.12 by vBS Debug Information
  • Page Generation 0.01279 seconds
  • Memory Usage 1,767KB
  • Queries Executed 11 (?)
More Information
Template Usage:
  • (1)SHOWTHREAD_SHOWPOST
  • (1)ad_footer_end
  • (1)ad_footer_start
  • (1)ad_header_end
  • (1)ad_header_logo
  • (1)ad_navbar_below
  • (1)bbcode_code
  • (1)footer
  • (1)gobutton
  • (1)header
  • (1)headinclude
  • (6)option
  • (1)post_thanks_box
  • (1)post_thanks_box_bit
  • (1)post_thanks_button
  • (1)post_thanks_javascript
  • (1)post_thanks_navbar_search
  • (1)post_thanks_postbit
  • (1)post_thanks_postbit_info
  • (1)postbit
  • (1)postbit_onlinestatus
  • (1)postbit_wrapper
  • (1)spacer_close
  • (1)spacer_open 

Phrase Groups Available:
  • global
  • postbit
  • reputationlevel
  • showthread
Included Files:
  • ./showpost.php
  • ./global.php
  • ./includes/init.php
  • ./includes/class_core.php
  • ./includes/config.php
  • ./includes/functions.php
  • ./includes/class_hook.php
  • ./includes/modsystem_functions.php
  • ./includes/functions_bigthree.php
  • ./includes/class_postbit.php
  • ./includes/class_bbcode.php
  • ./includes/functions_reputation.php
  • ./includes/functions_post_thanks.php 

Hooks Called:
  • init_startup
  • init_startup_session_setup_start
  • init_startup_session_setup_complete
  • cache_permissions
  • fetch_postinfo_query
  • fetch_postinfo
  • fetch_threadinfo_query
  • fetch_threadinfo
  • fetch_foruminfo
  • style_fetch
  • cache_templates
  • global_start
  • parse_templates
  • global_setup_complete
  • showpost_start
  • bbcode_fetch_tags
  • bbcode_create
  • postbit_factory
  • showpost_post
  • postbit_display_start
  • post_thanks_function_post_thanks_off_start
  • post_thanks_function_post_thanks_off_end
  • post_thanks_function_fetch_thanks_start
  • fetch_musername
  • post_thanks_function_fetch_thanks_end
  • post_thanks_function_thanked_already_start
  • post_thanks_function_thanked_already_end
  • post_thanks_function_fetch_thanks_bit_start
  • post_thanks_function_show_thanks_date_start
  • post_thanks_function_show_thanks_date_end
  • post_thanks_function_fetch_thanks_bit_end
  • post_thanks_function_fetch_post_thanks_template_start
  • post_thanks_function_fetch_post_thanks_template_end
  • postbit_imicons
  • bbcode_parse_start
  • bbcode_parse_complete_precache
  • bbcode_parse_complete
  • postbit_display_complete
  • post_thanks_function_can_thank_this_post_start
  • showpost_complete