View Single Post
  #352  
Old 07-28-2014, 04:27 AM
DragonByte Tech's Avatar
DragonByte Tech DragonByte Tech is offline
 
Join Date: Feb 2010
Location: Scotland
Posts: 8,814
Благодарил(а): 0 раз(а)
Поблагодарили: 0 раз(а) в 0 сообщениях
Default

Quote:
Originally Posted by Barbecue_Eater View Post
Thanks so far.
Which exact language setting are we talking about here?
I'll probably have to download the english language xml, we only have the German one.

I'm pretty sure there is nothing broken about the files, I remember having the bug before upgrading to the newer version (4.2.1 > 4.2.2).


EDIT:
By setting the language to English (US), the problem is resolved.
How do I fix it with the German language?

It's probably because of the decimal separator.
In the US, you use as a decimal separator - here in middle EU you use


The same applies to the thousand separator: you're using while we're using

But the code needs to be changed in order for the plugin to work properly.

.
.
.
.
-- EDIT 2: Our fix that we use from now:

I fixed it by changing Line 26 of dbtech\vbdonate\includes\functions.php to
Code:
$dbt_vbd_pp_amount_options = explode('/', $vbulletin->options['dbtech_vbdonate_don_amount']);
and started separating the amounts by the character "/" in the vBDonate settings and using a comma instead a dot as the decimal character.

This will not work for the english language pack though, therefore I suggest you guys implement an automatic parser that converts the amounts to the correlating decimal systems of the language. There is a vbulletin variable that can read the decimal character, you can use that automatically based on the users language setting.

Regards.
That's an interesting fix to the problem, I was going to post that it might be the issue. I'll see if I can work forward with that idea.

We have found with several things that the language decimals/separators are usually the issue. Changing the settings in the main options seems to work better than using the language separators.

I'll see if I can work a permanent fix in for you.

Matt
Reply With Quote
 
X vBulletin 3.8.12 by vBS Debug Information
  • Page Generation 0.01136 seconds
  • Memory Usage 1,769KB
  • Queries Executed 11 (?)
More Information
Template Usage:
  • (1)SHOWTHREAD_SHOWPOST
  • (1)ad_footer_end
  • (1)ad_footer_start
  • (1)ad_header_end
  • (1)ad_header_logo
  • (1)ad_navbar_below
  • (1)bbcode_code
  • (1)bbcode_quote
  • (1)footer
  • (1)gobutton
  • (1)header
  • (1)headinclude
  • (6)option
  • (1)post_thanks_box
  • (1)post_thanks_button
  • (1)post_thanks_javascript
  • (1)post_thanks_navbar_search
  • (1)post_thanks_postbit_info
  • (1)postbit
  • (1)postbit_onlinestatus
  • (1)postbit_wrapper
  • (1)spacer_close
  • (1)spacer_open 

Phrase Groups Available:
  • global
  • postbit
  • reputationlevel
  • showthread
Included Files:
  • ./showpost.php
  • ./global.php
  • ./includes/init.php
  • ./includes/class_core.php
  • ./includes/config.php
  • ./includes/functions.php
  • ./includes/class_hook.php
  • ./includes/modsystem_functions.php
  • ./includes/functions_bigthree.php
  • ./includes/class_postbit.php
  • ./includes/class_bbcode.php
  • ./includes/functions_reputation.php
  • ./includes/functions_post_thanks.php 

Hooks Called:
  • init_startup
  • init_startup_session_setup_start
  • init_startup_session_setup_complete
  • cache_permissions
  • fetch_postinfo_query
  • fetch_postinfo
  • fetch_threadinfo_query
  • fetch_threadinfo
  • fetch_foruminfo
  • style_fetch
  • cache_templates
  • global_start
  • parse_templates
  • global_setup_complete
  • showpost_start
  • bbcode_fetch_tags
  • bbcode_create
  • postbit_factory
  • showpost_post
  • postbit_display_start
  • post_thanks_function_post_thanks_off_start
  • post_thanks_function_post_thanks_off_end
  • post_thanks_function_fetch_thanks_start
  • post_thanks_function_fetch_thanks_end
  • post_thanks_function_thanked_already_start
  • post_thanks_function_thanked_already_end
  • fetch_musername
  • postbit_imicons
  • bbcode_parse_start
  • bbcode_parse_complete_precache
  • bbcode_parse_complete
  • postbit_display_complete
  • post_thanks_function_can_thank_this_post_start
  • showpost_complete