View Single Post
  #29  
Old 05-01-2002, 03:38 AM
Kaelon's Avatar
Kaelon Kaelon is offline
 
Join Date: Jan 2002
Posts: 405
Благодарил(а): 0 раз(а)
Поблагодарили: 0 раз(а) в 0 сообщениях
Default

Very nice hack, Vivi. I set up a private test forum - a fresh, clean install of 2.2.5, and mostly everything looks like it is functioning properly on the admin backend. I run into the first error at the "Donate" function. It looks like your hack doesn't escape apostrophe's appropriately. There are also some other bugs that I have itemized below for your reference.

1. No Apostrophe Escape

Quote:
Database error in vBulletin 2.2.5:

Invalid SQL: UPDATE items SET stock='5' WHERE name='Cat's Claws'
mysql error: You have an error in your SQL syntax near 's Claws'' at line 1

mysql error number: 1064

-- snip --

Referer:
I fixed the above problem by simply removing any problem items that used apostrophes ('). We also get the same errors when you try to add any Item whose name OR description have either an apostrophe or a quote (").

2. Donate Error

Your donate URL, as you specified it in postbits, is incorrect. The correct URL, whether or not you use JavaScript, should be as follows:

Code:
<a href="itemshop.php?action=donate&user=$post[userid]">Donate</a>
Previously, you didn't have the $post[userid] variable, and instead just referenced [userid]. Changing this fixed it for me.

3. Sold Item Graphic Remains

When you sell an item, the graphic for the previous (sold) item remains even though you have no item listed in the appropriate slot. When you purchase a new item, fortunately, the new item graphic icon replaces the old item graphic. This can be fixed if you clear out the value for your categorical icon in use.

I'll continue testing and let you know if I run into anything else.

Juan
Reply With Quote
 
X vBulletin 3.8.12 by vBS Debug Information
  • Page Generation 0.01115 seconds
  • Memory Usage 1,765KB
  • Queries Executed 11 (?)
More Information
Template Usage:
  • (1)SHOWTHREAD_SHOWPOST
  • (1)ad_footer_end
  • (1)ad_footer_start
  • (1)ad_header_end
  • (1)ad_header_logo
  • (1)ad_navbar_below
  • (1)bbcode_code
  • (1)bbcode_quote
  • (1)footer
  • (1)gobutton
  • (1)header
  • (1)headinclude
  • (6)option
  • (1)post_thanks_box
  • (1)post_thanks_button
  • (1)post_thanks_javascript
  • (1)post_thanks_navbar_search
  • (1)post_thanks_postbit_info
  • (1)postbit
  • (1)postbit_onlinestatus
  • (1)postbit_wrapper
  • (1)spacer_close
  • (1)spacer_open 

Phrase Groups Available:
  • global
  • postbit
  • reputationlevel
  • showthread
Included Files:
  • ./showpost.php
  • ./global.php
  • ./includes/init.php
  • ./includes/class_core.php
  • ./includes/config.php
  • ./includes/functions.php
  • ./includes/class_hook.php
  • ./includes/modsystem_functions.php
  • ./includes/functions_bigthree.php
  • ./includes/class_postbit.php
  • ./includes/class_bbcode.php
  • ./includes/functions_reputation.php
  • ./includes/functions_post_thanks.php 

Hooks Called:
  • init_startup
  • init_startup_session_setup_start
  • init_startup_session_setup_complete
  • cache_permissions
  • fetch_postinfo_query
  • fetch_postinfo
  • fetch_threadinfo_query
  • fetch_threadinfo
  • fetch_foruminfo
  • style_fetch
  • cache_templates
  • global_start
  • parse_templates
  • global_setup_complete
  • showpost_start
  • bbcode_fetch_tags
  • bbcode_create
  • postbit_factory
  • showpost_post
  • postbit_display_start
  • post_thanks_function_post_thanks_off_start
  • post_thanks_function_post_thanks_off_end
  • post_thanks_function_fetch_thanks_start
  • post_thanks_function_fetch_thanks_end
  • post_thanks_function_thanked_already_start
  • post_thanks_function_thanked_already_end
  • fetch_musername
  • postbit_imicons
  • bbcode_parse_start
  • bbcode_parse_complete_precache
  • bbcode_parse_complete
  • postbit_display_complete
  • post_thanks_function_can_thank_this_post_start
  • showpost_complete