View Single Post
  #3  
Old 04-16-2002, 11:36 AM
galt galt is offline
 
Join Date: Mar 2002
Location: USA
Posts: 48
Благодарил(а): 0 раз(а)
Поблагодарили: 0 раз(а) в 0 сообщениях
Default

Ah, the rigors of design debates...

First off, your requirement to have a post for a thread seems fine, and I can certainly do that, I just need to figure out the timing within the system I am developing.

As far as designs being lousy, in the "delete" issue I am referring to code design, not system design. A program should NEVER crash IMHO when it gets unexpected data or encounters database inconsistencies. Parent-child relationships can get messed up for a variety of reasons in any database that does not enforce referential integrity. There is nearly always a better response than crashing, usually to ignore it and move on. But I will be happy to revisit this debate-issue when I have fixed MY hack-bug. Some inconsistencies SHOULD be fatal, I just do not think (based on my current understanding) that this should be one of them.

I support this conclusion by the fact that I was able to post replies to this thread, and it only crashed when I tried to change the thread title. Apparently, lack of any posts was not so disturbing to the system, just this particular piece of code. I might be wrong, some of my testing was pretty late at night.

As far as "open" being a bad variable name, open is a keyword in quite a few of the languages I have worked in. It could reasonably be co-opted as a keyword in PHP version 9. There may also come a day when someone rewrites vB (or just writes some extensions or objects for it) in a new (not PHP) language where open IS a keyword. Since it is buried in the database, this will require an unnecessary variance between the PHP database and the (new language) database. You can see where this might lead. if jelsoft is the one to do it, they could make the databases consistent but would have to do some (significant?) code changes to the existing system. And this database change cascades into hacks and extensions written by other people.

Thanks firefly for the quick and clear response. Please don't take my comments as criticism, but more in the nature of good-hearted debate. As Jelsoft opens its system and more people incorporate it into other systems, you will no doubt encounter other opinions wiser than my own.
Reply With Quote
 
X vBulletin 3.8.12 by vBS Debug Information
  • Page Generation 0.01151 seconds
  • Memory Usage 1,764KB
  • Queries Executed 11 (?)
More Information
Template Usage:
  • (1)SHOWTHREAD_SHOWPOST
  • (1)ad_footer_end
  • (1)ad_footer_start
  • (1)ad_header_end
  • (1)ad_header_logo
  • (1)ad_navbar_below
  • (1)footer
  • (1)gobutton
  • (1)header
  • (1)headinclude
  • (6)option
  • (1)post_thanks_box
  • (1)post_thanks_button
  • (1)post_thanks_javascript
  • (1)post_thanks_navbar_search
  • (1)post_thanks_postbit_info
  • (1)postbit
  • (1)postbit_onlinestatus
  • (1)postbit_wrapper
  • (1)spacer_close
  • (1)spacer_open 

Phrase Groups Available:
  • global
  • postbit
  • reputationlevel
  • showthread
Included Files:
  • ./showpost.php
  • ./global.php
  • ./includes/init.php
  • ./includes/class_core.php
  • ./includes/config.php
  • ./includes/functions.php
  • ./includes/class_hook.php
  • ./includes/modsystem_functions.php
  • ./includes/functions_bigthree.php
  • ./includes/class_postbit.php
  • ./includes/class_bbcode.php
  • ./includes/functions_reputation.php
  • ./includes/functions_post_thanks.php 

Hooks Called:
  • init_startup
  • init_startup_session_setup_start
  • init_startup_session_setup_complete
  • cache_permissions
  • fetch_postinfo_query
  • fetch_postinfo
  • fetch_threadinfo_query
  • fetch_threadinfo
  • fetch_foruminfo
  • style_fetch
  • cache_templates
  • global_start
  • parse_templates
  • global_setup_complete
  • showpost_start
  • bbcode_fetch_tags
  • bbcode_create
  • postbit_factory
  • showpost_post
  • postbit_display_start
  • post_thanks_function_post_thanks_off_start
  • post_thanks_function_post_thanks_off_end
  • post_thanks_function_fetch_thanks_start
  • post_thanks_function_fetch_thanks_end
  • post_thanks_function_thanked_already_start
  • post_thanks_function_thanked_already_end
  • fetch_musername
  • postbit_imicons
  • bbcode_parse_start
  • bbcode_parse_complete_precache
  • bbcode_parse_complete
  • postbit_display_complete
  • post_thanks_function_can_thank_this_post_start
  • showpost_complete