View Single Post
  #1  
Old 06-16-2012, 01:07 PM
qpurser qpurser is offline
 
Join Date: Jul 2011
Posts: 275
Благодарил(а): 0 раз(а)
Поблагодарили: 0 раз(а) в 0 сообщениях
Default check my php/sql code pls....

Just started to play around with php and sql stuff but don't feel that comfortable with it yet.
I am trying to create a custom page with a member list on the fly. Our member list changes almost every 2 weeks and I wanted my users to be able to get an actual member list without me having to create one every time and post it somewhere.
I tried my coding as below out and works pretty well.
However I wanted to be sure I didn't forget anything that mitt use a lot of server resources. For example do I have to clear the sql request after the page is created? If so how do I do that.

Also I would like to add the "join date" field next to the username. When I just put in "join date" I get just that numeric number from the DB. How do I convert it to a readable date?

Thanks for any help or suggestions

Code:
<table width="100%" cellspacing="3" cellpadding="20">
<center><b><u><font color=#855b63 size=6>Memberlist <center></b></u></font>
<br />
<br />

<?php



$result_q = $vbulletin->db->query_read("SELECT username, joindate FROM user
									   WHERE user.usergroupid <> '12' AND user.usergroupid = '9' AND user.membergroupids <> '13'
   AND user.membergroupids NOT LIKE '%12%' ORDER 
    BY user.username");


if ($vbulletin->db->num_rows($result_q) >0)

{
	
     $i = 0;
    $max_columns = 4;
	
     while ($result_r = $vbulletin->db->fetch_array($result_q))
	
    {
		
	    // make the variables easy to deal with
      // extract($row);
	

       // open row if counter is zero
       if($i == 0)
          echo "<tr>";	
		  if($result_q != "" && $result_q != null)
		  
          echo "<td><center><font color=#855b63 size=3>$result_r[username] <center></font></td>";
    
       // increment counter - if counter = max columns, reset counter and close row
       if(++$i == $max_columns) 
       {
           echo "</tr>";
           $i=0;
       }  // end if 
   } // end while
} // end if results

// clean up table - makes your code valid!
if($i < $max_columns)
{
    for($j=$i; $j<$max_columns;$j++)
        echo "<td>&nbsp;</td>";
}
 ?>
</tr>
<form><input type="button" value=" Print this page "
onclick="window.print();return false;" /></form>
</table>
Reply With Quote
 
X vBulletin 3.8.12 by vBS Debug Information
  • Page Generation 0.01184 seconds
  • Memory Usage 1,769KB
  • Queries Executed 11 (?)
More Information
Template Usage:
  • (1)SHOWTHREAD_SHOWPOST
  • (1)ad_footer_end
  • (1)ad_footer_start
  • (1)ad_header_end
  • (1)ad_header_logo
  • (1)ad_navbar_below
  • (1)bbcode_code
  • (1)footer
  • (1)gobutton
  • (1)header
  • (1)headinclude
  • (6)option
  • (1)post_thanks_box
  • (1)post_thanks_button
  • (1)post_thanks_javascript
  • (1)post_thanks_navbar_search
  • (1)post_thanks_postbit_info
  • (1)postbit
  • (1)postbit_onlinestatus
  • (1)postbit_wrapper
  • (1)spacer_close
  • (1)spacer_open 

Phrase Groups Available:
  • global
  • postbit
  • reputationlevel
  • showthread
Included Files:
  • ./showpost.php
  • ./global.php
  • ./includes/init.php
  • ./includes/class_core.php
  • ./includes/config.php
  • ./includes/functions.php
  • ./includes/class_hook.php
  • ./includes/modsystem_functions.php
  • ./includes/functions_bigthree.php
  • ./includes/class_postbit.php
  • ./includes/class_bbcode.php
  • ./includes/functions_reputation.php
  • ./includes/functions_post_thanks.php 

Hooks Called:
  • init_startup
  • init_startup_session_setup_start
  • init_startup_session_setup_complete
  • cache_permissions
  • fetch_postinfo_query
  • fetch_postinfo
  • fetch_threadinfo_query
  • fetch_threadinfo
  • fetch_foruminfo
  • style_fetch
  • cache_templates
  • global_start
  • parse_templates
  • global_setup_complete
  • showpost_start
  • bbcode_fetch_tags
  • bbcode_create
  • postbit_factory
  • showpost_post
  • postbit_display_start
  • post_thanks_function_post_thanks_off_start
  • post_thanks_function_post_thanks_off_end
  • post_thanks_function_fetch_thanks_start
  • post_thanks_function_fetch_thanks_end
  • post_thanks_function_thanked_already_start
  • post_thanks_function_thanked_already_end
  • fetch_musername
  • postbit_imicons
  • bbcode_parse_start
  • bbcode_parse_complete_precache
  • bbcode_parse_complete
  • postbit_display_complete
  • post_thanks_function_can_thank_this_post_start
  • showpost_complete