Thread: Show Thread Enhancements - OS/Browser Display in Postbits
View Single Post
  #132  
Old 05-10-2012, 01:59 PM
EliasAlucard's Avatar
EliasAlucard EliasAlucard is offline
 
Join Date: Nov 2009
Location: Sweden
Posts: 125
Благодарил(а): 0 раз(а)
Поблагодарили: 0 раз(а) в 0 сообщениях
Default

Quote:
Originally Posted by nhawk View Post
I would prefer you didn't.

And I feel it's as complicated as it needs to be for what it does. If you disagree with that, use PMs and we'll discuss it.

Also, the system does identify Ubuntu, etc.
Well, if we may not come to agreement, I may just install it and use my own modification of it on my forum. I'm using vB3.8.7 now though, so I'm not using your plugin.

You've done a good job in adding more browser and OS support, but it's still quite incomplete (hey, I don't blame ya, I've learned myself that this takes quite some time).

We can take it here rather than PM. For one, I don't understand why you've grouped together Windows 7 and Server 2008 R2? They are clearly distinguishable by user agent string (6.1 and 6.0) and so it's possible to separate them in the postbit information. You also don't have a specific icon for Windows 7; you're using the Vista icon.

Personally, I think the icons should be sized at least 20 on the height and 24 as a max.

I wouldn't really need to modify your plugin though. I guess all I need is to add browser/OS version support for Fighter1405's old vB3.8 plugin, in the alt text. Do I need $tmp_array, $useragent and $client_data for that?
Reply With Quote
 
X vBulletin 3.8.12 by vBS Debug Information
  • Page Generation 0.02189 seconds
  • Memory Usage 1,763KB
  • Queries Executed 11 (?)
More Information
Template Usage:
  • (1)SHOWTHREAD_SHOWPOST
  • (1)ad_footer_end
  • (1)ad_footer_start
  • (1)ad_header_end
  • (1)ad_header_logo
  • (1)ad_navbar_below
  • (1)bbcode_quote
  • (1)footer
  • (1)gobutton
  • (1)header
  • (1)headinclude
  • (6)option
  • (1)post_thanks_box
  • (1)post_thanks_button
  • (1)post_thanks_javascript
  • (1)post_thanks_navbar_search
  • (1)post_thanks_postbit_info
  • (1)postbit
  • (1)postbit_onlinestatus
  • (1)postbit_wrapper
  • (1)spacer_close
  • (1)spacer_open 

Phrase Groups Available:
  • global
  • postbit
  • reputationlevel
  • showthread
Included Files:
  • ./showpost.php
  • ./global.php
  • ./includes/init.php
  • ./includes/class_core.php
  • ./includes/config.php
  • ./includes/functions.php
  • ./includes/class_hook.php
  • ./includes/modsystem_functions.php
  • ./includes/functions_bigthree.php
  • ./includes/class_postbit.php
  • ./includes/class_bbcode.php
  • ./includes/functions_reputation.php
  • ./includes/functions_post_thanks.php 

Hooks Called:
  • init_startup
  • init_startup_session_setup_start
  • init_startup_session_setup_complete
  • cache_permissions
  • fetch_postinfo_query
  • fetch_postinfo
  • fetch_threadinfo_query
  • fetch_threadinfo
  • fetch_foruminfo
  • style_fetch
  • cache_templates
  • global_start
  • parse_templates
  • global_setup_complete
  • showpost_start
  • bbcode_fetch_tags
  • bbcode_create
  • postbit_factory
  • showpost_post
  • postbit_display_start
  • post_thanks_function_post_thanks_off_start
  • post_thanks_function_post_thanks_off_end
  • post_thanks_function_fetch_thanks_start
  • post_thanks_function_fetch_thanks_end
  • post_thanks_function_thanked_already_start
  • post_thanks_function_thanked_already_end
  • fetch_musername
  • postbit_imicons
  • bbcode_parse_start
  • bbcode_parse_complete_precache
  • bbcode_parse_complete
  • postbit_display_complete
  • post_thanks_function_can_thank_this_post_start
  • showpost_complete