Thread: Add-On Releases - DownloadsII Create New Thread Add-On [vB4]
View Single Post
  #69  
Old 02-29-2012, 02:42 PM
Carpesimia Carpesimia is offline
 
Join Date: Jun 2011
Posts: 49
Благодарил(а): 0 раз(а)
Поблагодарили: 0 раз(а) в 0 сообщениях
Default

Quote:
Originally Posted by RS_Jelle View Post
That's not a bug. You enabled a debugging option.
Settings -> General Settings -> Add Template Name in HTML Comments -> No
I disagree. I have a need from time to time to turn on HTML comments to find a template issue. Both vBulletin and every other add-on I have behaves nicely with the HTML Comments turned on, except downloadsii. I consider this a bug.

For those who would like to fix it, here's a simple fix.

Find the plugin named "DownloadsII: Create Thread on Add".

Partway down, you will see some code that uses vbulletin templates to build the message that will be posted. Like this:

PHP Code:
    $templater vB_Template::create('downloadii_create_newthread');
    
$templater->register('id'$id);
    
$templater->register('dtitle'$dtitle);
    
$templater->register('ddesc'$ddesc);
    
$pagetext .= $templater->render();

    
// VB3 eval('$title .= "' . fetch_template('downloadii_create_newthread_title') . '";');
    
$templater vB_Template::create('downloadii_create_newthread_title');
    
$templater->register('dtitle'$dtitle);
    
$title .= $templater->render(); 
This takes the raw templates (including the html comments if you have the debugging turned on) to use for the message. Edit the above code like this:

PHP Code:
    $templater vB_Template::create('downloadii_create_newthread');
    
$templater->register('id'$id);
    
$templater->register('dtitle'$dtitle);
    
$templater->register('ddesc'$ddesc);
    
$pagetext .= $templater->render();
    
$pagetext preg_replace('/<!--(.*)-->/Uis'''$pagetext);

    
// VB3 eval('$title .= "' . fetch_template('downloadii_create_newthread_title') . '";');
    
$templater vB_Template::create('downloadii_create_newthread_title');
    
$templater->register('dtitle'$dtitle);
    
$title .= $templater->render();
    
$title preg_replace('/<!--(.*)-->/Uis'''$title); 
All I did was add a line after the template was evaluated to strip all HTML comments from what was rendered, once for the message and once for the title. These 2 SMALL edits are all that are needed to make this plugin play nice with the html comments debugging set to on.
Reply With Quote
Благодарность от:
Hippy
 
X vBulletin 3.8.12 by vBS Debug Information
  • Page Generation 0.01168 seconds
  • Memory Usage 1,798KB
  • Queries Executed 11 (?)
More Information
Template Usage:
  • (1)SHOWTHREAD_SHOWPOST
  • (1)ad_footer_end
  • (1)ad_footer_start
  • (1)ad_header_end
  • (1)ad_header_logo
  • (1)ad_navbar_below
  • (2)bbcode_php
  • (1)bbcode_quote
  • (1)footer
  • (1)gobutton
  • (1)header
  • (1)headinclude
  • (6)option
  • (1)post_thanks_box
  • (1)post_thanks_box_bit
  • (1)post_thanks_button
  • (1)post_thanks_javascript
  • (1)post_thanks_navbar_search
  • (1)post_thanks_postbit
  • (1)post_thanks_postbit_info
  • (1)postbit
  • (1)postbit_onlinestatus
  • (1)postbit_wrapper
  • (1)spacer_close
  • (1)spacer_open 

Phrase Groups Available:
  • global
  • postbit
  • reputationlevel
  • showthread
Included Files:
  • ./showpost.php
  • ./global.php
  • ./includes/init.php
  • ./includes/class_core.php
  • ./includes/config.php
  • ./includes/functions.php
  • ./includes/class_hook.php
  • ./includes/modsystem_functions.php
  • ./includes/functions_bigthree.php
  • ./includes/class_postbit.php
  • ./includes/class_bbcode.php
  • ./includes/functions_reputation.php
  • ./includes/functions_post_thanks.php 

Hooks Called:
  • init_startup
  • init_startup_session_setup_start
  • init_startup_session_setup_complete
  • cache_permissions
  • fetch_postinfo_query
  • fetch_postinfo
  • fetch_threadinfo_query
  • fetch_threadinfo
  • fetch_foruminfo
  • style_fetch
  • cache_templates
  • global_start
  • parse_templates
  • global_setup_complete
  • showpost_start
  • bbcode_fetch_tags
  • bbcode_create
  • postbit_factory
  • showpost_post
  • postbit_display_start
  • post_thanks_function_post_thanks_off_start
  • post_thanks_function_post_thanks_off_end
  • post_thanks_function_fetch_thanks_start
  • fetch_musername
  • post_thanks_function_fetch_thanks_end
  • post_thanks_function_thanked_already_start
  • post_thanks_function_thanked_already_end
  • post_thanks_function_fetch_thanks_bit_start
  • post_thanks_function_show_thanks_date_start
  • post_thanks_function_show_thanks_date_end
  • post_thanks_function_fetch_thanks_bit_end
  • post_thanks_function_fetch_post_thanks_template_start
  • post_thanks_function_fetch_post_thanks_template_end
  • postbit_imicons
  • bbcode_parse_start
  • bbcode_parse_complete_precache
  • bbcode_parse_complete
  • postbit_display_complete
  • post_thanks_function_can_thank_this_post_start
  • showpost_complete