[R-D]

Got a couple of bugfixes for you. Both in vboptimise/cachers/cacher_templates.php.

Line 27:

if (CMS_SCRIPT)

Should be:

if (defined('CMS_SCRIPT'))

Otherwise it always evaluates to true and includes the $add array of CMS templates, even if CMS_SCRIPT isn't defined. This means the datastore is checked unnecessarily for 40+ non-existent templates, if the CMS isn't installed.


Line 91:

foreach ($argument AS $template)
{
	$templateids[] = intval($templateassoc["$template"]);
}

Should be:

foreach ($argument AS $template)
{
	$tem = intval($templateassoc["$template"]);

	if ($tem > 0)
	{
		$templateids[] = $tem;
	}
}

This one is minor, compared to the other, but vBOptimise 2.0.1 looks for the humanverify template, which doesn't exist. It's included in a number of vBulletin pages, but is altered to the correct humanverify_type template in global.php, line 271 (vBulletin 3.8X).

Checking for a template ID greater than 0 would eliminate any additional datastore checking, if other templates don't exist but are included for whatever reason.