Thread: Add-On Releases - Everywhere Sidebar 4 VB4
View Single Post
  #1296  
Old 11-18-2011, 04:28 AM
almannai almannai is offline
 
Join Date: Oct 2007
Posts: 889
Благодарил(а): 0 раз(а)
Поблагодарили: 0 раз(а) в 0 сообщениях
Default

Quote:
Originally Posted by cb001 View Post
Couple of problems with the mod and CSS files.

1. If you store CSS as file it causes an invalid link which produces 404 errors.
2. It includes CSS files multiple times therefore leading to unnecessary round trips to the server.

I can demonstrate this with the reference implementation mentioned above: http://last24tech.com/forum.php

If you look at the source you will see that it first includes
<link rel="stylesheet" type="text/css" href="css.php?styleid=2&amp;langid=1&amp;d=1321553 939&amp;td=ltr&amp;sheet=forumbits.css,forumhome.c ss,widgets.css,sidebar.css,options.css,tagcloud.cs s" />

This is from the regular template. Then, just before the IE6 Tag, there is this include, and I think it is coming from the mod. Notice that the order is somewhat different but the files are identical.
<link rel="stylesheet" type="text/css" href="css.php?styleid=2&amp;langid=1&amp;d=1321553 939&amp;td=ltr&amp;sheet=sidebar.css,forumbits.css ,forumhome.css,tagcloud.css,widgets.css,options.cs s" />

I think this should be fixed.
1. I will look into that

2. Please Correct me if 'm wrong: the browsers are smart enough to not download same file again it will use the cached one. This is used for backward compatibility for vb.
Reply With Quote
 
X vBulletin 3.8.12 by vBS Debug Information
  • Page Generation 0.01399 seconds
  • Memory Usage 1,767KB
  • Queries Executed 11 (?)
More Information
Template Usage:
  • (1)SHOWTHREAD_SHOWPOST
  • (1)ad_footer_end
  • (1)ad_footer_start
  • (1)ad_header_end
  • (1)ad_header_logo
  • (1)ad_navbar_below
  • (1)bbcode_quote
  • (1)footer
  • (1)gobutton
  • (1)header
  • (1)headinclude
  • (6)option
  • (1)post_thanks_box
  • (1)post_thanks_button
  • (1)post_thanks_javascript
  • (1)post_thanks_navbar_search
  • (1)post_thanks_postbit_info
  • (1)postbit
  • (1)postbit_onlinestatus
  • (1)postbit_wrapper
  • (1)spacer_close
  • (1)spacer_open 

Phrase Groups Available:
  • global
  • postbit
  • reputationlevel
  • showthread
Included Files:
  • ./showpost.php
  • ./global.php
  • ./includes/init.php
  • ./includes/class_core.php
  • ./includes/config.php
  • ./includes/functions.php
  • ./includes/class_hook.php
  • ./includes/modsystem_functions.php
  • ./includes/functions_bigthree.php
  • ./includes/class_postbit.php
  • ./includes/class_bbcode.php
  • ./includes/functions_reputation.php
  • ./includes/functions_post_thanks.php 

Hooks Called:
  • init_startup
  • init_startup_session_setup_start
  • init_startup_session_setup_complete
  • cache_permissions
  • fetch_postinfo_query
  • fetch_postinfo
  • fetch_threadinfo_query
  • fetch_threadinfo
  • fetch_foruminfo
  • style_fetch
  • cache_templates
  • global_start
  • parse_templates
  • global_setup_complete
  • showpost_start
  • bbcode_fetch_tags
  • bbcode_create
  • postbit_factory
  • showpost_post
  • postbit_display_start
  • post_thanks_function_post_thanks_off_start
  • post_thanks_function_post_thanks_off_end
  • post_thanks_function_fetch_thanks_start
  • post_thanks_function_fetch_thanks_end
  • post_thanks_function_thanked_already_start
  • post_thanks_function_thanked_already_end
  • fetch_musername
  • postbit_imicons
  • bbcode_parse_start
  • bbcode_parse_complete_precache
  • bbcode_parse_complete
  • postbit_display_complete
  • post_thanks_function_can_thank_this_post_start
  • showpost_complete