[DragonByte Tech]

Originally Posted by Logician

Firstly thanks for the great hack. It is well written, has a clean code and from checking the source code, I can confirm that a lot of work is put into the project so frankly speaking I believe it is not appreciated enough. So I wanted to tell my appreciation for your work first! :-)

Thank you! You're actually the first person (outside the DBTech team ) that's complimented me on my code quality, so it really means a lot

Originally Posted by Logician

ISSUE 1:

[...]

I think it might be a good idea to:
1- Add a hack setting to enter custom parameters there. Alternatively you can make "IMAP Port" setting inputbox "string", instead of "number" which will then allow entering values like: 143/novalidate-cert

I presume there's no downside to adding novalidate-cert for everyone? Surely no servers can be set up to hard reject a connection that tries to skip certificate validation as opposed to simply ignoring that directive... Thinking out loud here. I'd prefer to have it working without requiring admins to edit the port like that

I've added the novalidate-cert and the imap_last_error() to the file and it'll be updated with the next version

Originally Posted by Logician

ISSUE 2:

In dbtech /vbmail/cron/threshold.php, this part:
[...]

Otherwise email part in the user pm is blank.

Whoops xD

Originally Posted by Logician

ISSUE 3:

The hack is not unflagging user if vb option "verifyemail" is turned off since you tied unflagging only to register.php user activation screen.

And this is the kicker that requires a new version number as opposed to a hotfix xD

I'll release it later tonight alongside a vBActivity & Awards update, thanks


Fillip