Firstly thanks for the great hack. It is well written, has a clean code and from checking the source code, I can confirm that a lot of work is put into the project so frankly speaking I believe it is not appreciated enough. So I wanted to tell my appreciation for your work first! :-)
I installed it in a friend's board. He wants to use for bounce email management and not interested in email listing features so my comments are regarding this part only. During installation I had some issues, glitches and fixes for them so I wanted to share with you considering you might want to know about them.
ISSUE 1:
During the initial installation the hack didn't work first. It gave no signal but it was not processing any bounced emails. After some debugging, I noticed that imap_open() was failing with error:
Warning: imap_open() [function.imap-open]: Couldn't open stream {mail.___.com:143/imap}Inbox in [path]/dbtech/vbmail/includes/class_imap.php on line 98
Although all login details were correct.
After some work I noticed our server is requiring /novalidate-cert parameter otherwise, it is dieing with error:
Certificate failure for
___.com: self signed certificate:
/C=US/ST=Unknown/L=Unknown/O=Unknown/OU=Unknown/CN=server1.____/emailAddress=ssl@server1.___"
So changing the line in dbtech/vbmail/includes/class_imap.php:
PHP Code:
self::$connection = imap_open(
'{' . self::$vbulletin->options['dbtech_vbmail_imap_host'] . ':' . self::$vbulletin->options['dbtech_vbmail_imap_port'] . '/imap' .
(self::$vbulletin->options['dbtech_vbmail_imap_ssl'] ? '/ssl/novalidate-cert' : '') .
(self::$vbulletin->options['dbtech_vbmail_imap_tls'] ? '/tls/novalidate-cert' : '') .
'}' . self::$vbulletin->options['dbtech_vbmail_imap_mailbox'],
self::$vbulletin->options['dbtech_vbmail_imap_username'],
self::$vbulletin->options['dbtech_vbmail_imap_password']
);
as
PHP Code:
//Logician Hack : Added /novalidate-cert as mail server is rejecting connection without this
self::$connection = imap_open(
'{' . self::$vbulletin->options['dbtech_vbmail_imap_host'] . ':' . self::$vbulletin->options['dbtech_vbmail_imap_port'] . '/novalidate-cert/imap' .
(self::$vbulletin->options['dbtech_vbmail_imap_ssl'] ? '/ssl/novalidate-cert' : '') .
(self::$vbulletin->options['dbtech_vbmail_imap_tls'] ? '/tls/novalidate-cert' : '') .
'}' . self::$vbulletin->options['dbtech_vbmail_imap_mailbox'],
self::$vbulletin->options['dbtech_vbmail_imap_username'],
self::$vbulletin->options['dbtech_vbmail_imap_password']
);
//Logician Hack : Added /novalidate-cert as mail server is rejecting connection without this
fixed this issue for us.
I think it might be a good idea to:
1- Add a hack setting to enter custom parameters there. Alternatively you can make "IMAP Port" setting inputbox "string", instead of "number" which will then allow entering values like: 143/novalidate-cert
2- In part:
PHP Code:
if (!self::$connection)
{
// We couldn't open the mailbox
trigger_error($vbphrase['dbtech_vbmail_cannot_open_mailbox'], E_USER_ERROR);
}
It might be helpful to vbmail() admin with the value of imap_last_error() variable as it will help debugging connection problems when hack can't connect to the mail server. ATM admin is in dark when a connection problem occurs as no error etc. are returned. (Even when scheduled task is run manually in admin cp)
ISSUE 2:
In dbtech /vbmail/cron/threshold.php, this part:
PHP Code:
$users = $vbulletin->db->query_read_slave("
SELECT
user.userid,
user.username,
user.usergroupid,
user.membergroupids,
user.infractiongroupid,
user.displaygroupid" . ($vbulletin->products['dbtech_vbshop'] ? ", user.dbtech_vbshop_purchase" : '') . "
FROM `" . TABLE_PREFIX . "dbtech_vbmail_message` AS dbtech_vbmail_message
INNER JOIN " . TABLE_PREFIX . "user AS user ON(user.email = dbtech_vbmail_message.fromaddress)
WHERE dbtech_vbmail_message.fromaddress != ''
AND dbtech_vbmail_message.bounce = '1'
AND user.dbtech_vbmail_bounceflag = '0'
GROUP BY dbtech_vbmail_message.fromaddress
HAVING COUNT(*) >= " . intval($vbulletin->options['dbtech_vbmail_bounce_threshold'])
);
Should be replaced as:
PHP Code:
$users = $vbulletin->db->query_read_slave("
SELECT
user.userid,
user.username,
user.email,
user.usergroupid,
user.membergroupids,
user.infractiongroupid,
user.displaygroupid" . ($vbulletin->products['dbtech_vbshop'] ? ", user.dbtech_vbshop_purchase" : '') . "
FROM `" . TABLE_PREFIX . "dbtech_vbmail_message` AS dbtech_vbmail_message
INNER JOIN " . TABLE_PREFIX . "user AS user ON(user.email = dbtech_vbmail_message.fromaddress)
WHERE dbtech_vbmail_message.fromaddress != ''
AND dbtech_vbmail_message.bounce = '1'
AND user.dbtech_vbmail_bounceflag = '0'
GROUP BY dbtech_vbmail_message.fromaddress
HAVING COUNT(*) >= " . intval($vbulletin->options['dbtech_vbmail_bounce_threshold'])
);
Otherwise email part in the user pm is blank.
ISSUE 3:
The hack is not unflagging user if vb option "verifyemail" is turned off since you tied unflagging only to register.php user activation screen. I added this pluggin to correct this issue for boards which does not use email confirmation:
HOOK LOCATION: profile_updatepassword_complete
PHP CODE:
Quote:
//Logician Hack : If user is not banned AND changed his email correctly AND email verification is OFF, THEN unflag dbtech_vbmail_bounceflag setting
if ($permissions['genericoptions'] & $vbulletin->bf_ugp_genericoptions['isnotbannedgroup'] AND ($vbulletin->GPC['email'] != $vbulletin->userinfo['email'] AND $vbulletin->GPC['email'] AND $vbulletin->GPC['emailconfirm'] == $vbulletin->GPC['email']) AND !$vbulletin->options['verifyemail'])
{
$onoff = '0';
$userdata->set('dbtech_vbmail_bounceflag', $onoff);
}
|
This fixed the issue for such boards.
If I run into other issues, I'll keep reporting.
And once again, thanks for the great hack and efforts put into it!
More Information