[CheeSie]

Moreeeeeeee XD

To fix that the user could just add themselves as the ones being disputed..

Add the following phrase.
Type: Error Messages
Product: LAM - Dispute Resolution
VarName: LAM_DisputeResolution_NoAddingSelf
Text: You cannot add yourself as one of those you are disputing.


Plugin: LAM - Check Edit Usernames Have Been Given
What has changed: Removed unused stuff (seriously learn to clean up) and added the above mentioned check
New code

if (!$vbulletin->GPC['ajax'] AND !$vbulletin->GPC['quickeditnoajax'] AND !$vbulletin->GPC['advanced'] AND ($threadinfo['postuserid'] == $vbulletin->userinfo['userid'] || can_moderate($threadinfo['forumid'], 'caneditthreads'))) {
	$vbulletin->input->clean_gpc('p', 'LAM_DisputeResolution_UserNames', TYPE_STR);

	if ($vbulletin->options['LAM_DisputeResolution_GlobalEnable'] || in_array($foruminfo['forumid'], explode(',', $vbulletin->options['LAM_DisputeResolution_DisputeForumIDs']))) {
		if (empty($vbulletin->GPC['LAM_DisputeResolution_UserNames'])) {
		
			if (!$vbulletin->options['LAM_DisputeResolution_OptionalDisputes']) {
				eval(standard_error(fetch_error('LAM_DisputeResolution_MissingUserNames')));
			}
			
		} else {
		
			$LAM_DisputeResolution_Names = explode(";", $vbulletin->GPC['LAM_DisputeResolution_UserNames']);

			foreach ($LAM_DisputeResolution_Names AS $LAM_DisputeResolution_Name) {
				$LAM_DisputeResolution_Name = $db->escape_string(trim($LAM_DisputeResolution_Name));
				
				if (!empty($LAM_DisputeResolution_Name)) {
					$LAM_DisputeResolution_Query = $db->query_first("SELECT userid FROM " . TABLE_PREFIX ."user AS user WHERE username = '$LAM_DisputeResolution_Name'");

					if ($LAM_DisputeResolution_Query) {
						if($LAM_DisputeResolution_Query['userid'] == $vbulletin->userinfo['userid']){
							eval(standard_error(fetch_error('LAM_DisputeResolution_NoAddingSelf')));
						}
						$db->free_result($LAM_DisputeResolution_Query);
					} else {
						eval(standard_error(fetch_error('LAM_DisputeResolution_UnknownUserName', $LAM_DisputeResolution_Name)));
					}
				}
			}
		}
		
		unset($LAM_DisputeResolution_Query, $LAM_DisputeResolution_Names, $LAM_DisputeResolution_UIDs);
	}
}

Plugin: LAM - Check Usernames Have Been Given
What has changed: Removed unused stuff (seriously learn to clean up) and added the above mentioned check
New code

$vbulletin->input->clean_gpc('p', 'LAM_DisputeResolution_UserNames', TYPE_STR);

if ($vbulletin->options['LAM_DisputeResolution_GlobalEnable'] || in_array($foruminfo['forumid'], explode(',', $vbulletin->options['LAM_DisputeResolution_DisputeForumIDs']))) {
	if (empty($vbulletin->GPC['LAM_DisputeResolution_UserNames'])) {
	
		if (!$vbulletin->options['LAM_DisputeResolution_OptionalDisputes']) {
			eval(standard_error(fetch_error('LAM_DisputeResolution_MissingUserNames')));
		}
		
	} else {
	
		$LAM_DisputeResolution_Names = explode(";", $vbulletin->GPC['LAM_DisputeResolution_UserNames']);

		foreach ($LAM_DisputeResolution_Names AS $LAM_DisputeResolution_Name) {
			$LAM_DisputeResolution_Name = $db->escape_string(trim($LAM_DisputeResolution_Name));
			
			if (!empty($LAM_DisputeResolution_Name)) {
				$LAM_DisputeResolution_Query = $db->query_first("SELECT userid FROM " . TABLE_PREFIX ."user AS user WHERE username = '$LAM_DisputeResolution_Name'");

				if ($LAM_DisputeResolution_Query) {
					if($LAM_DisputeResolution_Query['userid'] == $vbulletin->userinfo['userid']){
						eval(standard_error(fetch_error('LAM_DisputeResolution_NoAddingSelf')));
					}
					$db->free_result($LAM_DisputeResolution_Query);
				} else {
					eval(standard_error(fetch_error('LAM_DisputeResolution_UnknownUserName', $LAM_DisputeResolution_Name)));
				}
			}
		}
	}
	
	unset($LAM_DisputeResolution_Query, $LAM_DisputeResolution_Names, $LAM_DisputeResolution_UIDs);
}