[BirdOPrey5]

Version 2.1 Released

Full instructions in .zip file...

But basically there is now a required manual file edit- there is no way around this in order to get the thread count correct for master forums.

As Jennifer2010 pointed out the master forum would only count as many threads as were originally in the forum. This is especially an issue when the master forum contains very few threads and the slave forums contain many more threads. No page numbers (or not enough) will be produced.

The fix requires deleting 1 line from your forumdisplay.php file.

At approximately line 761 you will find this code:

PHP Code:

    ($hook = vBulletinHook::fetch_hook('forumdisplay_query_threadscount')) ? eval($hook) : false;

    # Include visible IN (0,1,2) in order to hit upon the 4 column index
    $threadscount = $db->query_first_slave("
      SELECT COUNT(*) AS threads,
      (
       SELECT COUNT(*) AS newthread
       FROM " . TABLE_PREFIX . "thread AS thread
       WHERE forumid = $foruminfo[forumid]
        AND lastpost > $lastread
        AND open <> 10
        AND sticky = 0
        $prefix_filter
        $visiblethreads
        $globalignore
        $limitothers
        $datecut
        $hook_query_where     
      ) AS newthread
        $hook_query_fields
        FROM " . TABLE_PREFIX . "thread AS thread
        $tachyjoin
        $hook_query_joins
        WHERE forumid = $foruminfo[forumid]
            AND sticky = 0
            $prefix_filter
            $visiblethreads
            $globalignore
            $limitothers
            $datecut
            $hook_query_where
    ");
    $totalthreads = $threadscount['threads'];
    $newthreads = $threadscount['newthread']; 


You must delete the 1st instance of: $hook_query_where

So your final code should look like:

PHP Code:

    ($hook = vBulletinHook::fetch_hook('forumdisplay_query_threadscount')) ? eval($hook) : false;

    # Include visible IN (0,1,2) in order to hit upon the 4 column index
    $threadscount = $db->query_first_slave("
      SELECT COUNT(*) AS threads,
      (
       SELECT COUNT(*) AS newthread
       FROM " . TABLE_PREFIX . "thread AS thread
       WHERE forumid = $foruminfo[forumid]
        AND lastpost > $lastread
        AND open <> 10
        AND sticky = 0
        $prefix_filter
        $visiblethreads
        $globalignore
        $limitothers
        $datecut
 
      ) AS newthread
        $hook_query_fields
        FROM " . TABLE_PREFIX . "thread AS thread
        $tachyjoin
        $hook_query_joins
        WHERE forumid = $foruminfo[forumid]
            AND sticky = 0
            $prefix_filter
            $visiblethreads
            $globalignore
            $limitothers
            $datecut
            $hook_query_where
    ");
    $totalthreads = $threadscount['threads'];
    $newthreads = $threadscount['newthread']; 


Save the file and replace your forumdisplay.php file with this one.

Then import/install the new product .xml file version 2.1.

NOTE- You MUST DELETE the entire line, you cannot "comment it out."

Also New in 2.1

You can now use an * to specify "ALL" forums be included in your master forum, such as:

2|*

Would make a master forum in forum id #2 that contains threads from EVERY forum on your site.