[Ted S]

Originally Posted by Tom Kagan

Nice product - well coded. Kudos!

A couple of nitpicks:

• Still some usage of '&' in some urls instead of '&'
• No need for './' when specifying href in anchor elements
• Hardcoded 'images/buttons' instead of using {vb:stylevar imgdir_button}
• Hardcoded <img> elements in .xml file lines 934-946 instead of in template
• Still using vb3.x syntax to specify stylevar color on <hr> which obviously doesn't work on vb4.x
• Still using vb3.x post url syntax 'showthread.php?p=<post#>#post<post#> to jump to post from stat screen instead of vb4.x canonical syntax 'showthread.php?t=<thread#>&viewfull=1&p=<post#>#p ost<post#>'
• Erroneous double call to $templater->render() in helpfulanswers.php lines 510 & 532
• Not really a need for a 2nd code path in helpfulanswers.php for 'guestrate' param. The 'rate' param path could just check if user is logged in.
• vb parameter 'sessionurl' and/or 'sessionurl_q' should be used in all cases
• Urls to posts should be run through the 'Friendly Urls' munger.
• Soft deleted posts should not show up in helpfulanswers statistics; user totals updated accordingly.
• Hard deleted posts should have helpfulanswer ratings on post also deleted
• Option 'Enable Single Post Voting' would probably be more useful per forum instead of global
• A minimum rep amount might be nice when using user's rep power or percentage
• 'Least Helpful Answers' stats/marking would be nice instead of just ignoring them.
• When you get it working, anonymous reporting should use class_vurl instead of curl
• Admincp deleting post ratings does not update helpfulpost
• Admincp option 'Enable Single Post Voting' is missing descriptive phrase due to phrase name misspelling
• Admincp phrases should be in own group instead of spread to various preexisting groups. There also appears to be some redundancies.
• Admincp 'Rating History and Editing' & 'Bulk Forum Enabler' should instead be in maintenance block
• Admincp needs way to repair/recalculate user totals due to system error/User merging/deleting etc.
• Admincp templates should be in own group instead of 'Help Templates'
• Using 'onmouseover', 'onmouseout' should be removed in favor of css 'hover'
• Using 'onclick' for AJAX call should be removed in favor of progressive enhancement style javascript. If done, <script> element could be moved to just before </body>

If the above were implemented along with some of your enhancements already planned, this hack would go from 'great' to 'near perfect'.

That's one heck of a list. Thanks.