[kh99]

Originally Posted by Hippy

the "Error 005". would happen when ?

I see the line is still $vs['start'] = $gametime;
if that error never happened should it still be changed to $vs['start'] = $gametime - 1.0;

Sorry, I don't remember the details. I think it only happened with IE in certain circumstances, maybe only with certain games (but I do remember that I was able to get it to happen when I wanted). I guess if no one's ever complained then there's probably no reason to change it. It's a hack - something later is subtracted from the gametime (or the other way around) and if it's 0 it causes an error, so I made sure it was never 0. I don't even know if that was a reasonable way to fix it, for all I know I was just disabling a check that was put in there for a reason I don't understand.

please explain a little more about exec_shut_down();
I am not sure if it's still needed

what was it doing with out it before.. thanks

To keep the session from timing out, init.php calls $vbulletin->session->do_lastvisit_update(). I guess for guests it works OK, but for logged in users it updates the session table with the current time, but it does it with db->shutdown_query(), which just queues it up to be run at shutdown (I don't know why - to speed up page loading maybe?). Anyway, it turns out that it's usually called by print_output() which isn't called in holdsession.php. I remember all that pretty well because I spent hours trying to figure out why the session was timing out even though holdsession.php was being requested. But like I said, that was 3.8 code so if you're working on version 4 it might not be true any more.

I suppose it's also possible I made a mistake somewhere alone the line...