Thread: Major Additions - 8WayRun.Com - Media Library
View Single Post
  #806  
Old 05-16-2010, 04:24 PM
DragonByte Tech's Avatar
DragonByte Tech DragonByte Tech is offline
 
Join Date: Feb 2010
Location: Scotland
Posts: 8,814
Благодарил(а): 0 раз(а)
Поблагодарили: 0 раз(а) в 0 сообщениях
Default

Quote:
Originally Posted by Jaxel View Post
I've found hundreds of websites all discussing the issue of urlencoding in JavaScript and how there is no real match to the PHP function. They all go into these long winded functions in order to fix the problem, talking about issues of escaping etc... and not ONE of them mentions this PHP.urlencode function. In fact, I can't even find any documentation on the internet that this function exists... which is bizarre, since it clearly works. PHP and JavaScript can't even be used at the same time because PHP is server side and JavaScript is client side. So in order for this function to work, it has to exist in JavaScript. So I guess my next question is, WHY? Why do none of these other articles mention this function? What is the downside? Is there a performance issue? Backwards compatibility? It seems like such a simple fix, while escape() just creates more problems...
It's a function vBulletin creates in their JS files, to solve just the problems you mention

There's no downsides that I'm aware of.

Quote:
Originally Posted by Jaxel View Post
BTW, I use UTF-8... and many of the people who've I've convinced to switch to UTF-8 have all reported to me that their forums are faster than ever... I just recently had shoryuken.com switch over and even their users are happy about it.
vBulletin itself isn't 100% UTF-8 compatible, though.
I can't comment on speed increases, never tried it tbh.

At any rate, it shouldn't be necessary to make them switch when it can work via that simple function, no?


Fillip
Reply With Quote
 
X vBulletin 3.8.12 by vBS Debug Information
  • Page Generation 0.01248 seconds
  • Memory Usage 1,765KB
  • Queries Executed 11 (?)
More Information
Template Usage:
  • (1)SHOWTHREAD_SHOWPOST
  • (1)ad_footer_end
  • (1)ad_footer_start
  • (1)ad_header_end
  • (1)ad_header_logo
  • (1)ad_navbar_below
  • (2)bbcode_quote
  • (1)footer
  • (1)gobutton
  • (1)header
  • (1)headinclude
  • (6)option
  • (1)post_thanks_box
  • (1)post_thanks_button
  • (1)post_thanks_javascript
  • (1)post_thanks_navbar_search
  • (1)post_thanks_postbit_info
  • (1)postbit
  • (1)postbit_onlinestatus
  • (1)postbit_wrapper
  • (1)spacer_close
  • (1)spacer_open 

Phrase Groups Available:
  • global
  • postbit
  • reputationlevel
  • showthread
Included Files:
  • ./showpost.php
  • ./global.php
  • ./includes/init.php
  • ./includes/class_core.php
  • ./includes/config.php
  • ./includes/functions.php
  • ./includes/class_hook.php
  • ./includes/modsystem_functions.php
  • ./includes/functions_bigthree.php
  • ./includes/class_postbit.php
  • ./includes/class_bbcode.php
  • ./includes/functions_reputation.php
  • ./includes/functions_post_thanks.php 

Hooks Called:
  • init_startup
  • init_startup_session_setup_start
  • init_startup_session_setup_complete
  • cache_permissions
  • fetch_postinfo_query
  • fetch_postinfo
  • fetch_threadinfo_query
  • fetch_threadinfo
  • fetch_foruminfo
  • style_fetch
  • cache_templates
  • global_start
  • parse_templates
  • global_setup_complete
  • showpost_start
  • bbcode_fetch_tags
  • bbcode_create
  • postbit_factory
  • showpost_post
  • postbit_display_start
  • post_thanks_function_post_thanks_off_start
  • post_thanks_function_post_thanks_off_end
  • post_thanks_function_fetch_thanks_start
  • post_thanks_function_fetch_thanks_end
  • post_thanks_function_thanked_already_start
  • post_thanks_function_thanked_already_end
  • fetch_musername
  • postbit_imicons
  • bbcode_parse_start
  • bbcode_parse_complete_precache
  • bbcode_parse_complete
  • postbit_display_complete
  • post_thanks_function_can_thank_this_post_start
  • showpost_complete