Thread: Major Additions - 8WayRun.Com - Media Library
View Single Post
  #791  
Old 05-14-2010, 09:31 PM
DragonByte Tech's Avatar
DragonByte Tech DragonByte Tech is offline
 
Join Date: Feb 2010
Location: Scotland
Posts: 8,814
Благодарил(а): 0 раз(а)
Поблагодарили: 0 раз(а) в 0 сообщениях
Default

Quote:
Originally Posted by Jaxel View Post
Wow... looking through DBTech's code for their Shoutbox, all I can do is put my head down in shame that they call themselves programmers.
Thanks for the input there =)

Oh a little advice, you might want to try wrapping your function declarations in function_exists(). If you do not, then errors occur if the function is declared more than once. It's standard practice for most coders. Please do let us know if theres a good reason not to do this though, we're always happy to learn more efficient ways of coding.

For instance, your code will also produce errors if vBulletin's fetch_tag_list() function is called once, and then again with $force_all set to true. Just a little heads up on that for you =)


Quote:
Originally Posted by Jaxel View Post
Apparently, their shoutbox redeclares several built in vbulletin libraries, rather than actually use the ones that are built into vbulletin. And people wonder why so many mods are so bloated? Its easy to see when you have mods like this that pretty much double up the size of the code.
Hmm, Only one library is redeclared, in order to overcome a small shortcoming in the default vB library.

You seem to be having some issues reading the code, If you have any questions on how to do this, or on how to properly wrap functions, we'd be happy to help you out.

Quote:
Originally Posted by Jaxel View Post
What makes this even worse is that DBTech charges $250 for a pro version of this mod.
P.S, as pointed out above, our shoutbox is not $250 – Not sure if you're deliberately mis-representing things to detract attention from your own shortcomings, or if you actually went to the wrong site, read the wrong code and the wrong price. Thats the only other alternative I can think of?

Regardless, Hope that clears things up for you, Good luck with your mods =)

Iain
Reply With Quote
 
X vBulletin 3.8.12 by vBS Debug Information
  • Page Generation 0.01151 seconds
  • Memory Usage 1,767KB
  • Queries Executed 11 (?)
More Information
Template Usage:
  • (1)SHOWTHREAD_SHOWPOST
  • (1)ad_footer_end
  • (1)ad_footer_start
  • (1)ad_header_end
  • (1)ad_header_logo
  • (1)ad_navbar_below
  • (3)bbcode_quote
  • (1)footer
  • (1)gobutton
  • (1)header
  • (1)headinclude
  • (6)option
  • (1)post_thanks_box
  • (1)post_thanks_button
  • (1)post_thanks_javascript
  • (1)post_thanks_navbar_search
  • (1)post_thanks_postbit_info
  • (1)postbit
  • (1)postbit_onlinestatus
  • (1)postbit_wrapper
  • (1)spacer_close
  • (1)spacer_open 

Phrase Groups Available:
  • global
  • postbit
  • reputationlevel
  • showthread
Included Files:
  • ./showpost.php
  • ./global.php
  • ./includes/init.php
  • ./includes/class_core.php
  • ./includes/config.php
  • ./includes/functions.php
  • ./includes/class_hook.php
  • ./includes/modsystem_functions.php
  • ./includes/functions_bigthree.php
  • ./includes/class_postbit.php
  • ./includes/class_bbcode.php
  • ./includes/functions_reputation.php
  • ./includes/functions_post_thanks.php 

Hooks Called:
  • init_startup
  • init_startup_session_setup_start
  • init_startup_session_setup_complete
  • cache_permissions
  • fetch_postinfo_query
  • fetch_postinfo
  • fetch_threadinfo_query
  • fetch_threadinfo
  • fetch_foruminfo
  • style_fetch
  • cache_templates
  • global_start
  • parse_templates
  • global_setup_complete
  • showpost_start
  • bbcode_fetch_tags
  • bbcode_create
  • postbit_factory
  • showpost_post
  • postbit_display_start
  • post_thanks_function_post_thanks_off_start
  • post_thanks_function_post_thanks_off_end
  • post_thanks_function_fetch_thanks_start
  • post_thanks_function_fetch_thanks_end
  • post_thanks_function_thanked_already_start
  • post_thanks_function_thanked_already_end
  • fetch_musername
  • postbit_imicons
  • bbcode_parse_start
  • bbcode_parse_complete_precache
  • bbcode_parse_complete
  • postbit_display_complete
  • post_thanks_function_can_thank_this_post_start
  • showpost_complete