Some suggestions:
1. Fix the missing <dt> in the postbit. It's making the definition list XHTML invalid and causing some
incompatibilities with other mods.
Current style:
Quote:
Thanks: x
Thanked x times in x posts
|
Suggested style:
Quote:
Thanks: x
Thanked: x times in x posts
|
2. Get rid of the inline CSS for people with CSS stored as files. With the new XML based CSS rollups you can merge it into showthread-rollup.css
And put a conditional around the JavaScript include so it's not loaded for people who can't thank a thread. Less includes give you a better Google page speed result.
Create /includes/xml/
cssrollup_postthanks.xml
Code:
<?xml version="1.0" encoding="ISO-8859-1"?>
<css product="post_thanks">
<rollup name="showthread-rollup.css">
<template>postthanks.css</template>
</rollup>
</css>
and create a new
postthanks.css template with the raw CSS.
Then put some conditionals into the
post_thanks_javascript template:
Code:
<vb:if condition="permission to thank">
<script type="text/javascript" src="clientscript/post_thanks.js"></script>
</vb:if>
<vb:if condition="!$vboptions['storecssasfile']">
<link rel="stylesheet" type="text/css" href="{vb:raw vbcsspath}postthanks.css" />
</vb:if>