[bira]

FireFly, you shouldn't remove it. I'll explain:

In the send new pm form, there are two hidden fields (original code):

<input type="hidden" name="prevmessageid" value="$privatemessageid">
<input type="hidden" name="forward" value="$forward">

These determine the behaviour of your icons in the PM folder:

if $privatemessageid has a value, then it means you are now replying to or forwarding a message. If it doesn't have a value, it means you are writing a new message.

if $privatemessageid has a value and $forward=1, it means you are forwarding a message and not replying.

These then determine which icon will be displayed in your inbox next to that message.

Now, when you click on "Reply" for a message, these values are filled.

When you hit "Preview", these values are lost.

So we need to "reinstate" them.

That's what these two lines are for:

$privatemessageid = $prevmessageid;
$forward;

From what you are telling me, I can only assume you have high error reporting set in php.ini.

For the vast majority of the people, that error won't show up because they are not in development environment with high error reporting, and functionality is not tampered.

However, if you want to be "holier than the pope" so to speak, do this instead:

PHP Code:

if ($prevmessageid) {
       $privatemessageid = $prevmessageid;
}

$forward = iif($forward,1,0); 


I think this should work. Try it out and let me know

Cheers,

Bira