View Single Post
  #358  
Old 02-28-2010, 01:38 AM
Zachery's Avatar
Zachery Zachery is offline
 
Join Date: Jul 2002
Location: Ontario, Canada
Posts: 11,440
Благодарил(а): 0 раз(а)
Поблагодарили: 0 раз(а) в 0 сообщениях
Default

I really like the idea's of these mods, I just wish that they'd actually improve things instead of possibly cause more issues.

If you're already having page load time issues, some of this addon is going to cause even more problems for you.

You should be loading YUI from a remote source, it means that your users only have to have one set of YUI files cache. If they visit any other VB sites that also load remotely they dont have to request the files. It also increases thier browsing speed of the site because their browser can send requests for these files while waiting for your other site files(by default in browsers only do 2 requests per site at a time). Moving it back onto your site mimimized or not isn't helping. FWIW we already compress the files by default for vBulletin unless you download the package sans compressed javascript. -2

Serving Compressed CSS is actually a good idea, +1

Compressing templates in REALTIME (as in every single page load) is a HORRIBLE idea. This is adding COUNTLESS cpu cycles and making php do even more work then it was already doing to make your pages load. FWIW fully gziped/mod_deflated html with whitepsace removal is 3-5% improvement on average. If you really need to squeeze that much preformance, you should do it ONCE and only ONCE ever. When you save the template you can compress its contents. You can also extend the post cacheing system to compress its html whitespace there as well. -5

The attachment optmizer is probably not bad, but I didn't look at the code here. +0


So overall this addon does more to harm your site than help it, at least as it stands now. Just something to think about
Reply With Quote
 
X vBulletin 3.8.12 by vBS Debug Information
  • Page Generation 0.02239 seconds
  • Memory Usage 1,761KB
  • Queries Executed 11 (?)
More Information
Template Usage:
  • (1)SHOWTHREAD_SHOWPOST
  • (1)ad_footer_end
  • (1)ad_footer_start
  • (1)ad_header_end
  • (1)ad_header_logo
  • (1)ad_navbar_below
  • (1)footer
  • (1)gobutton
  • (1)header
  • (1)headinclude
  • (6)option
  • (1)post_thanks_box
  • (1)post_thanks_button
  • (1)post_thanks_javascript
  • (1)post_thanks_navbar_search
  • (1)post_thanks_postbit_info
  • (1)postbit
  • (1)postbit_onlinestatus
  • (1)postbit_wrapper
  • (1)spacer_close
  • (1)spacer_open 

Phrase Groups Available:
  • global
  • postbit
  • reputationlevel
  • showthread
Included Files:
  • ./showpost.php
  • ./global.php
  • ./includes/init.php
  • ./includes/class_core.php
  • ./includes/config.php
  • ./includes/functions.php
  • ./includes/class_hook.php
  • ./includes/modsystem_functions.php
  • ./includes/functions_bigthree.php
  • ./includes/class_postbit.php
  • ./includes/class_bbcode.php
  • ./includes/functions_reputation.php
  • ./includes/functions_post_thanks.php 

Hooks Called:
  • init_startup
  • init_startup_session_setup_start
  • init_startup_session_setup_complete
  • cache_permissions
  • fetch_postinfo_query
  • fetch_postinfo
  • fetch_threadinfo_query
  • fetch_threadinfo
  • fetch_foruminfo
  • style_fetch
  • cache_templates
  • global_start
  • parse_templates
  • global_setup_complete
  • showpost_start
  • bbcode_fetch_tags
  • bbcode_create
  • postbit_factory
  • showpost_post
  • postbit_display_start
  • post_thanks_function_post_thanks_off_start
  • post_thanks_function_post_thanks_off_end
  • post_thanks_function_fetch_thanks_start
  • post_thanks_function_fetch_thanks_end
  • post_thanks_function_thanked_already_start
  • post_thanks_function_thanked_already_end
  • fetch_musername
  • postbit_imicons
  • bbcode_parse_start
  • bbcode_parse_complete_precache
  • bbcode_parse_complete
  • postbit_display_complete
  • post_thanks_function_can_thank_this_post_start
  • showpost_complete