vb.org Archive - View Single Post - BB Code Enhancements

BRotondi · #**609** 02-25-2010, 11:50 AM

The encluded Plugin link sorttable javascript in <head>-section on hook global_complete does not work with vB4 and with vB4.0.1/2 it will even break vb-scripts like vbulletin_multi_quote.js!

Code:

if(($vbulletin->options['stg_table_options']&64)&&in_array(THIS_SCRIPT, array('announcement','calendar','editpost', 'newreply','newthread','private','showpost','showthread','usernote'))){
    $output = str_replace('</head>',"\t".'<style type="text/css">'."\n\t\tspan.sortarrow {position:absolute;}\n\t\tspan.sortarrow img {border:0;}\n\t\ta.sortheader {text-decoration:none; display:block; width:100%;}\n\t</style>\n\t".'<script type="text/javascript">'."\n\t\t".'var IMGDIR_BUTTON = "'.$stylevar['imgdir_button'].'";'."\n\t".'</script>'."\n\t".'<script type="text/javascript" src="clientscript/sorttable.js"></script>'."\n".'</head>',$output);
}

The red part sets IMGDIR_BUTTON to "" since $stylevar['imgdir_button'] cannot be referenced this way any more. Effect: Eg Multiquote cannot be used any more since vbulletin_multi_quote.js uses it to reference the multiquote-buttons.

Solution: Disable this PlugIn, since the sorting does not work any more in vB4.0.2. I tried to hardencode stylevar['imgdir_button']:

Code:

if(($vbulletin->options['stg_table_options']&64)&&in_array(THIS_SCRIPT, array('announcement','calendar','editpost', 'newreply','newthread','private','showpost','showthread','usernote'))){
    $output = str_replace('</head>',"\t".'<style type="text/css">'."\n\t\tspan.sortarrow {position:absolute;}\n\t\tspan.sortarrow img {border:0;}\n\t\ta.sortheader {text-decoration:none; display:block; width:100%;}\n\t</style>\n\t".'<script type="text/javascript">'."\n\t\t".'var IMGDIR_BUTTON = "images/buttons";'."\n\t".'</script>'."\n\t".'<script type="text/javascript" src="clientscript/sorttable.js"></script>'."\n".'</head>',$output);
}

but this helps only for the Multiquote, not for sorting...

German Thread about this Bug: 'Beitrag zum Zitieren ausw?hlen' defekt.

Greetings, Bruno

(Again: The Addon works fine with vB4, but the sorting plugin has to be disabled!)

X vBulletin 3.8.12 by vBS Debug Information
Page Generation 0.02541 seconds Memory Usage 1,767KB Queries Executed 11 (?)
More Information
Template Usage: (1)SHOWTHREAD_SHOWPOST (1)ad_footer_end (1)ad_footer_start (1)ad_header_end (1)ad_header_logo (1)ad_navbar_below (2)bbcode_code (1)footer (1)gobutton (1)header (1)headinclude (6)option (1)post_thanks_box (1)post_thanks_button (1)post_thanks_javascript (1)post_thanks_navbar_search (1)post_thanks_postbit_info (1)postbit (1)postbit_onlinestatus (1)postbit_wrapper (1)spacer_close (1)spacer_open Phrase Groups Available: global postbit reputationlevel showthread	Included Files: ./showpost.php ./global.php ./includes/init.php ./includes/class_core.php ./includes/config.php ./includes/functions.php ./includes/class_hook.php ./includes/modsystem_functions.php ./includes/functions_bigthree.php ./includes/class_postbit.php ./includes/class_bbcode.php ./includes/functions_reputation.php ./includes/functions_post_thanks.php Hooks Called: init_startup init_startup_session_setup_start init_startup_session_setup_complete cache_permissions fetch_postinfo_query fetch_postinfo fetch_threadinfo_query fetch_threadinfo fetch_foruminfo style_fetch cache_templates global_start parse_templates global_setup_complete showpost_start bbcode_fetch_tags bbcode_create postbit_factory showpost_post postbit_display_start post_thanks_function_post_thanks_off_start post_thanks_function_post_thanks_off_end post_thanks_function_fetch_thanks_start post_thanks_function_fetch_thanks_end post_thanks_function_thanked_already_start post_thanks_function_thanked_already_end fetch_musername postbit_imicons bbcode_parse_start bbcode_parse_complete_precache bbcode_parse_complete postbit_display_complete post_thanks_function_can_thank_this_post_start showpost_complete
Messages: