Thread: Chat Modifications - VSa - ChatBox (AJAX)
View Single Post
  #645  
Old 02-21-2010, 07:55 AM
denman75 denman75 is offline
 
Join Date: Aug 2006
Location: Netherlands
Posts: 228
Благодарил(а): 0 раз(а)
Поблагодарили: 0 раз(а) в 0 сообщениях
Default

Quote:
Originally Posted by RedFoxy View Post
Ok I "fixed" it with a patch on the template, just it don't show the edit's buttons, vsa-chatbox need a real fix to prevent a JavaScript and vsa-chatbox's code injection about edit.

To patch it you must:

Open: vsa_chatbox

Search:
Code:
				<td width="1%" align="{vb:stylevar right}">{vb:rawphrase edit}&nbsp;</td>
Replace with:
Code:
				<vb:if condition="(($bbuserinfo[userid]==$vsacb_msg_arc[userid]) AND $vsacb_canmod) OR $vsacb_canmod">
					<td width="1%" align="{vb:stylevar right}">{vb:rawphrase edit}&nbsp;</td>
				</vb:if>


Open: vsa_chatbox_archive_bit

Search:
Code:
					<vb:if condition="($bbuserinfo[userid]==$vsacb_msg_arc[userid]) OR $vsacb_canmod">
Replace with:
Code:
					<vb:if condition="(($bbuserinfo[userid]==$vsacb_msg_arc[userid]) AND $vsacb_canmod) OR $vsacb_canmod">
Search:
Code:
		<vb:if condition="($bbuserinfo[userid]==$vsacb_msg_arc[userid]) OR $vsacb_canmod">
Replace with:
Code:
		<vb:if condition="(($bbuserinfo[userid]==$vsacb_msg_arc[userid]) AND $vsacb_canmod) OR $vsacb_canmod">

REMEMBER THAT IS A PATCH THAT DON'T SOLVE DEFINITELY THE TROUBLE, it don't fix the javascript or the code, a user with right knowledge can bypass that patch and use directly the javascript to edit the messages





thanks Redfoxy ,my site wont allowed trading also ,so i made the changes u suggested.
But is it possible that the mods and admins ,now also cant edit user messages on my board .since the edit box is gone lol
i have inserted the right user-group permissions

ps this should be inserted in the next release thats its not possible to edit messages
for the rest great mod
Reply With Quote
 
X vBulletin 3.8.12 by vBS Debug Information
  • Page Generation 0.01267 seconds
  • Memory Usage 1,776KB
  • Queries Executed 11 (?)
More Information
Template Usage:
  • (1)SHOWTHREAD_SHOWPOST
  • (1)ad_footer_end
  • (1)ad_footer_start
  • (1)ad_header_end
  • (1)ad_header_logo
  • (1)ad_navbar_below
  • (6)bbcode_code
  • (1)bbcode_quote
  • (1)footer
  • (1)gobutton
  • (1)header
  • (1)headinclude
  • (6)option
  • (1)post_thanks_box
  • (1)post_thanks_button
  • (1)post_thanks_javascript
  • (1)post_thanks_navbar_search
  • (1)post_thanks_postbit_info
  • (1)postbit
  • (1)postbit_onlinestatus
  • (1)postbit_wrapper
  • (1)spacer_close
  • (1)spacer_open 

Phrase Groups Available:
  • global
  • postbit
  • reputationlevel
  • showthread
Included Files:
  • ./showpost.php
  • ./global.php
  • ./includes/init.php
  • ./includes/class_core.php
  • ./includes/config.php
  • ./includes/functions.php
  • ./includes/class_hook.php
  • ./includes/modsystem_functions.php
  • ./includes/functions_bigthree.php
  • ./includes/class_postbit.php
  • ./includes/class_bbcode.php
  • ./includes/functions_reputation.php
  • ./includes/functions_post_thanks.php 

Hooks Called:
  • init_startup
  • init_startup_session_setup_start
  • init_startup_session_setup_complete
  • cache_permissions
  • fetch_postinfo_query
  • fetch_postinfo
  • fetch_threadinfo_query
  • fetch_threadinfo
  • fetch_foruminfo
  • style_fetch
  • cache_templates
  • global_start
  • parse_templates
  • global_setup_complete
  • showpost_start
  • bbcode_fetch_tags
  • bbcode_create
  • postbit_factory
  • showpost_post
  • postbit_display_start
  • post_thanks_function_post_thanks_off_start
  • post_thanks_function_post_thanks_off_end
  • post_thanks_function_fetch_thanks_start
  • post_thanks_function_fetch_thanks_end
  • post_thanks_function_thanked_already_start
  • post_thanks_function_thanked_already_end
  • fetch_musername
  • postbit_imicons
  • bbcode_parse_start
  • bbcode_parse_complete_precache
  • bbcode_parse_complete
  • postbit_display_complete
  • post_thanks_function_can_thank_this_post_start
  • showpost_complete