View Single Post
  #824  
Old 02-05-2010, 05:27 PM
RS_Jelle RS_Jelle is offline
 
Join Date: Jul 2005
Posts: 1,276
Благодарил(а): 0 раз(а)
Поблагодарили: 0 раз(а) в 0 сообщениях
Default

Thanks for this great mod

Some suggestions:
1. A setting to control the default height of the chat box.
2. An archive page to view the older shouts.

Some small fixes:

1. Remove from gcbos.php:
PHP Code:
define('NO_REGISTER_GLOBALS'1); 
This is deprecated. vBulletin isn't using this any more.

2. Replace the cache_templates plugin code with:
PHP Code:
$cache[] = 'GCBOS'
When caching only one or two templates, this is faster than array_merge().

3. Replace
HTML Code:
<script src="clientscript/gcbos.js"></script>
with
HTML Code:
<script type="text/javascript" src="clientscript/gcbos.js"></script>
to make it XHTML valid.

4. In the GCBOS template replace
HTML Code:
<img src="images/buttons/collapse_40b.png" alt="" title="Collapse this Category">
with
HTML Code:
<img src="images/buttons/collapse_40b.png" alt="" title="{vb:rawphrase collapse_this_category}" />
to make it XHTML valid and to phrase it (it's a global phrase, so it works for sure).

5. In the GCBOS template replace
HTML Code:
<input type="text" id="gcbos_input" style="width: 92%; height: 19px; margin: 1px;float:left;" autocomplete="off" />
with
HTML Code:
<input type="text" id="gcbos_input" style="width: 92%; height: 19px; margin: 1px;float:left;" />
to make it XHTML valid. Autocomplete isn't a valid XHTML attribute. I don't think it's required for the AJAX to function in this case?

6. Hide the notice by default
HTML Code:
<div class="forumrowdata">
	<p class="subforumdescription" id="gcbos_notice" style="display:none"></p>			
</div>
and then use style.display = 'block' in the JavaScript to show it when there actually is a notice. This avoids an empty bar.
Reply With Quote
 
X vBulletin 3.8.12 by vBS Debug Information
  • Page Generation 0.01158 seconds
  • Memory Usage 1,781KB
  • Queries Executed 11 (?)
More Information
Template Usage:
  • (1)SHOWTHREAD_SHOWPOST
  • (1)ad_footer_end
  • (1)ad_footer_start
  • (1)ad_header_end
  • (1)ad_header_logo
  • (1)ad_navbar_below
  • (7)bbcode_html
  • (2)bbcode_php
  • (1)footer
  • (1)gobutton
  • (1)header
  • (1)headinclude
  • (6)option
  • (1)post_thanks_box
  • (1)post_thanks_button
  • (1)post_thanks_javascript
  • (1)post_thanks_navbar_search
  • (1)post_thanks_postbit_info
  • (1)postbit
  • (1)postbit_onlinestatus
  • (1)postbit_wrapper
  • (1)spacer_close
  • (1)spacer_open 

Phrase Groups Available:
  • global
  • postbit
  • reputationlevel
  • showthread
Included Files:
  • ./showpost.php
  • ./global.php
  • ./includes/init.php
  • ./includes/class_core.php
  • ./includes/config.php
  • ./includes/functions.php
  • ./includes/class_hook.php
  • ./includes/modsystem_functions.php
  • ./includes/functions_bigthree.php
  • ./includes/class_postbit.php
  • ./includes/class_bbcode.php
  • ./includes/functions_reputation.php
  • ./includes/functions_post_thanks.php 

Hooks Called:
  • init_startup
  • init_startup_session_setup_start
  • init_startup_session_setup_complete
  • cache_permissions
  • fetch_postinfo_query
  • fetch_postinfo
  • fetch_threadinfo_query
  • fetch_threadinfo
  • fetch_foruminfo
  • style_fetch
  • cache_templates
  • global_start
  • parse_templates
  • global_setup_complete
  • showpost_start
  • bbcode_fetch_tags
  • bbcode_create
  • postbit_factory
  • showpost_post
  • postbit_display_start
  • post_thanks_function_post_thanks_off_start
  • post_thanks_function_post_thanks_off_end
  • post_thanks_function_fetch_thanks_start
  • post_thanks_function_fetch_thanks_end
  • post_thanks_function_thanked_already_start
  • post_thanks_function_thanked_already_end
  • fetch_musername
  • postbit_imicons
  • bbcode_parse_start
  • bbcode_parse_complete_precache
  • bbcode_parse_complete
  • postbit_display_complete
  • post_thanks_function_can_thank_this_post_start
  • showpost_complete