Thread: Major Additions - MySmilies vB (v3.8.0)
View Single Post
  #145  
Old 01-17-2010, 03:43 PM
choccyclaire choccyclaire is offline
 
Join Date: Jan 2008
Posts: 235
Благодарил(а): 0 раз(а)
Поблагодарили: 0 раз(а) в 0 сообщениях
Default

I'm using the previous version of that particular plugin for now and all seems to be working okay apart from quoting.

(I am not much of a coder) Why did you need to change this plugin? What differs to make the mod more effective.

Old code:

Code:
if (!isset($GLOBALS['mysmiliesvb_userid']) OR empty($GLOBALS['mysmiliesvb_userid']))
{
	// Just in case... just depending on $GLOBALS['mysmiliesvb_userid'] without this
	// check didn't work for me on previews when editing signature.
	$GLOBALS['mysmiliesvb_userid'] = $this->registry->userinfo['userid'];
}

if ($this->registry->options['mysmiliesvb_option_masterswitch'] AND $GLOBALS['mysmiliesvb_userid'])
{
	$smiliesurlbase = $this->registry->options['mysmiliesvb_option_smiliesurl'];
	$smilies = $this->registry->db->query("
		SELECT *
		FROM " . TABLE_PREFIX . "mysmiliesvb
		WHERE userid='{$GLOBALS['mysmiliesvb_userid']}'
	");

	while ($smilie = $this->registry->db->fetch_array($smilies))
	{
		if (empty($smilie['smilietext_parsed']))
		{
			continue;
		}

		eval('$smilie[\'image\'] = "' . fetch_template('mysmilies_imagebit') . '";');

		$text = preg_replace("@" . $smilie['smilietext_parsed'] . "@isU", $smilie['image'], $text);
		$this->cached['text'] = $text;
	}
}
New code:

Code:
if (!isset($GLOBALS['mysmiliesvb_userid']) OR empty($GLOBALS['mysmiliesvb_userid']))
{
	// Just in case... just depending on $GLOBALS['mysmiliesvb_userid'] without this
	// check didn't work for me on previews when editing signature.
	$GLOBALS['mysmiliesvb_userid'] = $this->registry->userinfo['userid'];
}

if ($this->registry->options['mysmiliesvb_option_masterswitch'] AND $GLOBALS['mysmiliesvb_userid'] AND !empty($this->registry->sv_mysmiliesvb))
{
	$smiliesurlbase = $this->registry->options['mysmiliesvb_option_smiliesurl'];

	foreach ($this->registry->sv_mysmiliesvb AS $smilie)
	{
		eval('$smilie[\'image\'] = "' . fetch_template('mysmilies_imagebit') . '";');

		$text = preg_replace("@" . $smilie['smilietext_parsed'] . "@isU", $smilie['image'], $text);
		$this->cached['text'] = $text;
	}
}
I see mention of the database in the old version. Does that mean I will create more queries by altering this?
Reply With Quote
 
X vBulletin 3.8.12 by vBS Debug Information
  • Page Generation 0.01025 seconds
  • Memory Usage 1,768KB
  • Queries Executed 11 (?)
More Information
Template Usage:
  • (1)SHOWTHREAD_SHOWPOST
  • (1)ad_footer_end
  • (1)ad_footer_start
  • (1)ad_header_end
  • (1)ad_header_logo
  • (1)ad_navbar_below
  • (2)bbcode_code
  • (1)footer
  • (1)gobutton
  • (1)header
  • (1)headinclude
  • (6)option
  • (1)post_thanks_box
  • (1)post_thanks_button
  • (1)post_thanks_javascript
  • (1)post_thanks_navbar_search
  • (1)post_thanks_postbit_info
  • (1)postbit
  • (1)postbit_onlinestatus
  • (1)postbit_wrapper
  • (1)spacer_close
  • (1)spacer_open 

Phrase Groups Available:
  • global
  • postbit
  • reputationlevel
  • showthread
Included Files:
  • ./showpost.php
  • ./global.php
  • ./includes/init.php
  • ./includes/class_core.php
  • ./includes/config.php
  • ./includes/functions.php
  • ./includes/class_hook.php
  • ./includes/modsystem_functions.php
  • ./includes/functions_bigthree.php
  • ./includes/class_postbit.php
  • ./includes/class_bbcode.php
  • ./includes/functions_reputation.php
  • ./includes/functions_post_thanks.php 

Hooks Called:
  • init_startup
  • init_startup_session_setup_start
  • init_startup_session_setup_complete
  • cache_permissions
  • fetch_postinfo_query
  • fetch_postinfo
  • fetch_threadinfo_query
  • fetch_threadinfo
  • fetch_foruminfo
  • style_fetch
  • cache_templates
  • global_start
  • parse_templates
  • global_setup_complete
  • showpost_start
  • bbcode_fetch_tags
  • bbcode_create
  • postbit_factory
  • showpost_post
  • postbit_display_start
  • post_thanks_function_post_thanks_off_start
  • post_thanks_function_post_thanks_off_end
  • post_thanks_function_fetch_thanks_start
  • post_thanks_function_fetch_thanks_end
  • post_thanks_function_thanked_already_start
  • post_thanks_function_thanked_already_end
  • fetch_musername
  • postbit_imicons
  • bbcode_parse_start
  • bbcode_parse_complete_precache
  • bbcode_parse_complete
  • postbit_display_complete
  • post_thanks_function_can_thank_this_post_start
  • showpost_complete