Thread: Forum Display Enhancements - Filter Closed Threads
View Single Post
  #13  
Old 11-30-2009, 10:04 PM
Zarxrax Zarxrax is offline
 
Join Date: Mar 2009
Posts: 41
Благодарил(а): 0 раз(а)
Поблагодарили: 0 раз(а) в 0 сообщениях
Default

This plugin has a bug in the way it stores the cookie. I don't know enough about the code to be able to fix it, but I found out what is causing the problem.

If you allow the plugin to show the setting to the user, then some users will have a problem where the page wont properly load (the error message in my previous post)
I'm not sure why it only effects some users, but I noticed that the problem didn't effect me. However, one day, without having made any changes to my forum, the problem started effecting me as well.

But anyways, I tried taking out the part of the code that sets the cookie. After I did that, it started working again (but obviously you can't change the setting).

This is the code I removed, so I guess something in this is causing the problem:

Code:
if ($foruminfo['forumid'] AND $foruminfo['fct_allow_user_set'])
{
  // try to get saved state
  if ($vbulletin->userinfo['userid'] > 0)
  {
    // is state saved by user
    $fct_state_saved =
      array_key_exists("$foruminfo[forumid]", $vbulletin->userinfo['fct_data'])
        ? true
        : false;

    // get saved or default value
    $filterclosedthreads =
      $fct_state_saved
        // saved state
        ? $vbulletin->userinfo['fct_data']["$foruminfo[forumid]"]
        // default state
        : $foruminfo['fct_hide_by_default'];

    unset($fct_state_saved);
  }

  if (!empty($vbulletin->GPC['closed']))
  {
    $fct_temp_state =
      $vbulletin->GPC['closed'] == 'hide'
        ? 1
        : 0;

    if ($fct_temp_state != $filterclosedthreads)
    {
      global $usercache;

      // update saved state
      $filterclosedthreads = $fct_temp_state;

      if ($vbulletin->userinfo['userid'] > 0)
      {
        $fct_userid = $vbulletin->userinfo['userid'];

        // update cache
        if(isset($usercache["$fct_userid"]))
        {
          $usercache["$fct_userid"]['fct_data']["$foruminfo[forumid]"] =
            $filterclosedthreads;
        }

        // update user profile
        $vbulletin->userinfo['fct_data']["$foruminfo[forumid]"] =
          $filterclosedthreads;

        // init user data manager
        $fct_userdata =& datamanager_init('User', $vbulletin, ERRTYPE_STANDARD);
        $fct_userdata->set_existing($vbulletin->userinfo);
        $fct_userdata->save();

        unset($fct_userdata, $fct_userid);
      }
    }

    unset($fct_temp_state);
  }
}
Reply With Quote
 
X vBulletin 3.8.12 by vBS Debug Information
  • Page Generation 0.01555 seconds
  • Memory Usage 1,768KB
  • Queries Executed 11 (?)
More Information
Template Usage:
  • (1)SHOWTHREAD_SHOWPOST
  • (1)ad_footer_end
  • (1)ad_footer_start
  • (1)ad_header_end
  • (1)ad_header_logo
  • (1)ad_navbar_below
  • (1)bbcode_code
  • (1)footer
  • (1)gobutton
  • (1)header
  • (1)headinclude
  • (6)option
  • (1)post_thanks_box
  • (1)post_thanks_button
  • (1)post_thanks_javascript
  • (1)post_thanks_navbar_search
  • (1)post_thanks_postbit_info
  • (1)postbit
  • (1)postbit_onlinestatus
  • (1)postbit_wrapper
  • (1)spacer_close
  • (1)spacer_open 

Phrase Groups Available:
  • global
  • postbit
  • reputationlevel
  • showthread
Included Files:
  • ./showpost.php
  • ./global.php
  • ./includes/init.php
  • ./includes/class_core.php
  • ./includes/config.php
  • ./includes/functions.php
  • ./includes/class_hook.php
  • ./includes/modsystem_functions.php
  • ./includes/functions_bigthree.php
  • ./includes/class_postbit.php
  • ./includes/class_bbcode.php
  • ./includes/functions_reputation.php
  • ./includes/functions_post_thanks.php 

Hooks Called:
  • init_startup
  • init_startup_session_setup_start
  • init_startup_session_setup_complete
  • cache_permissions
  • fetch_postinfo_query
  • fetch_postinfo
  • fetch_threadinfo_query
  • fetch_threadinfo
  • fetch_foruminfo
  • style_fetch
  • cache_templates
  • global_start
  • parse_templates
  • global_setup_complete
  • showpost_start
  • bbcode_fetch_tags
  • bbcode_create
  • postbit_factory
  • showpost_post
  • postbit_display_start
  • post_thanks_function_post_thanks_off_start
  • post_thanks_function_post_thanks_off_end
  • post_thanks_function_fetch_thanks_start
  • post_thanks_function_fetch_thanks_end
  • post_thanks_function_thanked_already_start
  • post_thanks_function_thanked_already_end
  • fetch_musername
  • postbit_imicons
  • bbcode_parse_start
  • bbcode_parse_complete_precache
  • bbcode_parse_complete
  • postbit_display_complete
  • post_thanks_function_can_thank_this_post_start
  • showpost_complete