[AfterWorldForum]

Quick revision to my edit in post 1523.

One of my users found that someone had been able to bid less than the starting price, and it's due to me having been sloppy.

And another edit further down. Look for:


Code:

	              if ($item['price'] + $item['inc'] > $vbulletin->GPC['bid']) {
	                  eval(standard_error(fetch_error('vbay_bid_higher')));
	              }
              if ($item['bids'] > 0) {

Replace with:

Code:

              if ($item['bids'] > 0) {
	              if ($item['price'] + $item['inc'] > $vbulletin->GPC['bid']) {
	                  eval(standard_error(fetch_error('vbay_bid_higher')));
	              }

I intended this to work and only insist the price + inc would be required after an initial bid was made. After all, if you're the first bidder on Ebay, you perfectly well can make an offer equal to the quoted startbid.

But my fix was incomplete. When there were no bids, it would be possible to bid whatever one liked. EVEN if that price was below the start price.

Luckily, the fix is also easy:

If you made the fix mentioned above, find this in the code:

              if ($item['bids'] > 0) 
				 {
	              if ($item['price'] + $item['inc'] > $vbulletin->GPC['bid']) {
	                  eval(standard_error(fetch_error('vbay_bid_higher')));
	              }
                  $pmhigh_bidder = $vbulletin->db->query("select * from " . TABLE_PREFIX . "user where userid='{$item['highbidder']}'");
                  $pmbidder = $vbulletin->db->fetch_array($pmhigh_bidder);
                  $title = "$vbphrase[vbay_pm_you_have_been_outbid] {$item['name']}";
                  $message = $vbphrase['vbay_pm_you_have_been_outbid_message'];
                  send_pm($vbulletin->userinfo['username'], $vbulletin->userinfo['userid'], $pmbidder['username'], $title, $message);
              }

Below that, add:

			  // Ensure that bid is higher thandesired opening bid
			  else
			  {
					if ($item['price'] > $vbulletin->GPC['bid']) {
	                  eval(standard_error(fetch_error('vbay_bid_higher')));
	              }
			  }

A thousand pardons to everyone.

Still a great mod, though. Anxiously awaiting the next version. I might throw in some loggin features when the next version is available, but I figured I'd wait before going down that road.

By the way, will it be possible to somehow skip reimporting the languages and phrases? I reworded quite a bit, and would prefer keeping my edits