[theksmith]

please excuse if this was already posted, but didn't see it on a quick skim of all 16 pages...


Problem:
after going to paypal to make donation, returning to the forum sends you to the "smilies" page instead of the "thank you" page

you should be returning to:
yoursite.com/forum/misc.php?do=donate_thanks

but instead are returning to:
yoursite.com/forum/misc.php?merchant_return_link=Return+to+Offroad+Pa ssport


Fix
go to AdminCP > Plugin Manager > Cyb - PayPal Donate - Ext

change this line:

PHP Code:

if ($_REQUEST['do']=='donate_thanks') 


to this:

PHP Code:

if ($_REQUEST['do']=='donate_thanks' || isset($_REQUEST['merchant_return_link'])) 


Notes
- the fix mentioned by cybernetic in post #77 seems to already be included in the latest versions, but this still does not fix the current problem.

- the problem is with the current way paypal is working, not just the CYB - Donate mod. if you look at the source of final paypal page, you will see they are receiving the correct return url "yoursite.com/forum/misc.php?do=donate_thanks" but instead of linking to that url, they are doing a Form GET command which obliterates the "?do=donate_thanks" with their own usless querystring. cybernetic, i assume paypal now has a way to pass not only a return url, but also some return querystring params... to busy to look into it right now, this would be the ideal fix.

- this fix is a hack and *could* interfere with other products you might have that link to and then return from paypal