View Single Post
  #756  
Old 07-23-2009, 10:35 AM
The Geek's Avatar
The Geek The Geek is offline
 
Join Date: Sep 2003
Location: Behind you
Posts: 2,779
Благодарил(а): 0 раз(а)
Поблагодарили: 0 раз(а) в 0 сообщениях
Default

Quote:
Originally Posted by Charles_1 View Post
I have similar issue on vBulletin v3.8.2 and AME v2.5.5.
The example above isn't related to this. Those examples were working as intended as embedding was disabled (in fact, neither of those videos are valid links anymore anyway)

Quote:
When I post full URL (http://www.youtube.com/watch?v=i8OLcbxZ0cA) everything is OK, player will appear. But when I post URL without http://, it shows only link with this target:
http://www.svethardware.cz/forum/www...?v=i8OLcbxZ0cA

It adds URL of our forum to beginning and link is of course not working. How to change it please? Besides that this mod is great becouse users don't need to learn something new, thanks.
However this I just confirmed as indeed a bug. The bug is that if no protocol is included (i.e. no http://) then the link will be malformed. I have included the fix in the next release but as I am heading out on Holiday Saturday, Ill post it here for those that want to apply the fix sooner.

in includes/ame_bbcode.php on or around line 492 find

PHP Code:
$url str_replace(array("[url]""[URL]""[/url]""[/URL]"), array("","","",""), $param1); 
and directly below it, add:

PHP Code:
        if (!preg_match('#^[a-z0-9]+(?<!about|javascript|vbscript|data):#si'$url))
        {
            
$url "http://$url";
        } 
HTHs
Reply With Quote
 
X vBulletin 3.8.12 by vBS Debug Information
  • Page Generation 0.01253 seconds
  • Memory Usage 1,780KB
  • Queries Executed 11 (?)
More Information
Template Usage:
  • (1)SHOWTHREAD_SHOWPOST
  • (1)ad_footer_end
  • (1)ad_footer_start
  • (1)ad_header_end
  • (1)ad_header_logo
  • (1)ad_navbar_below
  • (2)bbcode_php
  • (2)bbcode_quote
  • (1)footer
  • (1)gobutton
  • (1)header
  • (1)headinclude
  • (6)option
  • (1)post_thanks_box
  • (1)post_thanks_button
  • (1)post_thanks_javascript
  • (1)post_thanks_navbar_search
  • (1)post_thanks_postbit_info
  • (1)postbit
  • (1)postbit_onlinestatus
  • (1)postbit_wrapper
  • (1)spacer_close
  • (1)spacer_open 

Phrase Groups Available:
  • global
  • postbit
  • reputationlevel
  • showthread
Included Files:
  • ./showpost.php
  • ./global.php
  • ./includes/init.php
  • ./includes/class_core.php
  • ./includes/config.php
  • ./includes/functions.php
  • ./includes/class_hook.php
  • ./includes/modsystem_functions.php
  • ./includes/functions_bigthree.php
  • ./includes/class_postbit.php
  • ./includes/class_bbcode.php
  • ./includes/functions_reputation.php
  • ./includes/functions_post_thanks.php 

Hooks Called:
  • init_startup
  • init_startup_session_setup_start
  • init_startup_session_setup_complete
  • cache_permissions
  • fetch_postinfo_query
  • fetch_postinfo
  • fetch_threadinfo_query
  • fetch_threadinfo
  • fetch_foruminfo
  • style_fetch
  • cache_templates
  • global_start
  • parse_templates
  • global_setup_complete
  • showpost_start
  • bbcode_fetch_tags
  • bbcode_create
  • postbit_factory
  • showpost_post
  • postbit_display_start
  • post_thanks_function_post_thanks_off_start
  • post_thanks_function_post_thanks_off_end
  • post_thanks_function_fetch_thanks_start
  • post_thanks_function_fetch_thanks_end
  • post_thanks_function_thanked_already_start
  • post_thanks_function_thanked_already_end
  • fetch_musername
  • postbit_imicons
  • bbcode_parse_start
  • bbcode_parse_complete_precache
  • bbcode_parse_complete
  • postbit_display_complete
  • post_thanks_function_can_thank_this_post_start
  • showpost_complete