[sargatanas]

Originally Posted by MrEyes

There is a "bug" in the current product file:

On install you get the following error:

Database error in vBulletin 3.8.0:

Invalid SQL:
CREATE TABLE IF NOT EXISTSapplicator_app (
`appid` INT( 10 ) NOT NULL AUTO_INCREMENT ,
`appname` VARCHAR( 100 ) NOT NULL DEFAULT 'Name',
`appactive` TINYINT( 1 ) NOT NULL DEFAULT '1',
`appperms` VARCHAR( 150 ) NOT NULL DEFAULT '0',
UNIQUE (
`appid`
)
);

MySQL Error   : You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near 'EXISTSapplicator_app (
`appid` INT( 10 ) NOT NULL AUTO_INCREMENT ,
`appname` V' at line 1
Error Number  : 1064
Request Date  : Tuesday, May 19th 2009 @ 10:37:40 PM
Error Date    : Tuesday, May 19th 2009 @ 10:37:40 PM
Script        : http://www.wibble.com/admincp/plugin.php
Referrer      : http://www.wibble.com/admincp/plugin.php?do=productadd
IP Address    : 90.213.65.43
Username      : Wibble
Classname     : vB_Database
MySQL Version : 5.0.45-community-nt

This is becuase of a missing space in the product XML, the following line:

$vbulletin->db->query_write("CREATE TABLE IF NOT EXISTS".TABLE_PREFIX."`applicator_question` (

Should be:

$vbulletin->db->query_write("CREATE TABLE IF NOT EXISTS ".TABLE_PREFIX."`applicator_question` (

Notice the space after EXISTS

Also there is a bug in the navbits, at the moment navbits is set using this code:

$navbits[$parent] = $vbphrase['bs_newbattle'];

and that phrase doesn't exists and isn't created by the product install, for now I have changed this to:

$navbits[$parent] = 'Applications'

However it would be better if this was the name of the application being viewed.

Also, I need to ask some fairly long questions but the question DB field is only 150 characters, so I have changed this to MEDIUMTEXT

And finally, if a user submits an application and then tries to resubmit another they get a standard (unphrased) "Error while posting application. Please try again." message - if the user has already submitted then it should really display their current submission and remove the submit button - or even better have a config value for each application that sets whether the user can resubmit.

Looks like a fantastic mod, but need a little polish before it is ready to go on live sites.

very well said. :up: