Thread: Miscellaneous Hacks - Live Topic
View Single Post
  #749  
Old 04-23-2009, 07:39 AM
voter's Avatar
voter voter is offline
 
Join Date: Dec 2006
Posts: 192
Благодарил(а): 0 раз(а)
Поблагодарили: 0 раз(а) в 0 сообщениях
Default

Coders Shack why you need to invent vbphrase variables in javascript?
Code in your php
Code:
			<script type=\"text/javascript\">
				var threadid = $threadinfo[threadid];
				var ajax_last_edit = $threadinfo[lastedit];
				livetopic.old_topic = ' . $vbulletin->options['livetopic_threadtime'] . ';
				livetopic.interval_time = ' . $vbulletin->options['livetopic_requestinterval'] . ';
				livetopic.ajax_max_visibleposts = ' . $vbulletin->options['livetopic_maxvisibleposts'] . ';

				vbphrase[\"livetopic_maxpostnotice\"] = \"' . addslashes($vbphrase['livetopic_maxpostnotice']) . '\";
				vbphrase[\"livetopic_edit_message\"] = \"' . addslashes($vbphrase['livetopic_edit_message']) . '\";
				vbphrase[\"livetopic_newresponses\"] = \"' . addslashes($vbphrase['livetopic_newresponses']) . '\";
			</script>
Generated this in html source

Quote:
<script type="text/javascript">
var threadid = 12290;
var ajax_last_edit = 1240437167;
livetopic.old_topic = 300;
livetopic.interval_time = 3000;
livetopic.ajax_max_visibleposts = 30;

vbphrase["livetopic_maxpostnotice"] = "The maximum amount of posts on this page can display has been reached. Posts will now start to disappear from oldest to newest.";
vbphrase["livetopic_edit_message"] = "<img alt=\'live topic\' src=\'images/statusicon/thread_livetopic.gif\' title=\'live topic\'/>&nbsp; <span style=\'font-weight: bold;\'>This post has been added by another user.</span> <br /><br />Since this is an active topic, this post has been automatically added to the thread while you were reading it. If you are replying to this thread you might want to read this post before doing so.";
vbphrase["livetopic_newresponses"] = "%1 new responses (<a href=\'showthread.php?t=%2&goto=newpost\'>live topic</a>)";
</script>
It is nonsense and useless to have vbphrase variables definition inside HTML source. These all is classified as HTML error from any HTML checker.
Reply With Quote
 
X vBulletin 3.8.12 by vBS Debug Information
  • Page Generation 0.01107 seconds
  • Memory Usage 1,768KB
  • Queries Executed 11 (?)
More Information
Template Usage:
  • (1)SHOWTHREAD_SHOWPOST
  • (1)ad_footer_end
  • (1)ad_footer_start
  • (1)ad_header_end
  • (1)ad_header_logo
  • (1)ad_navbar_below
  • (1)bbcode_code
  • (1)bbcode_quote
  • (1)footer
  • (1)gobutton
  • (1)header
  • (1)headinclude
  • (6)option
  • (1)post_thanks_box
  • (1)post_thanks_button
  • (1)post_thanks_javascript
  • (1)post_thanks_navbar_search
  • (1)post_thanks_postbit_info
  • (1)postbit
  • (1)postbit_onlinestatus
  • (1)postbit_wrapper
  • (1)spacer_close
  • (1)spacer_open 

Phrase Groups Available:
  • global
  • postbit
  • reputationlevel
  • showthread
Included Files:
  • ./showpost.php
  • ./global.php
  • ./includes/init.php
  • ./includes/class_core.php
  • ./includes/config.php
  • ./includes/functions.php
  • ./includes/class_hook.php
  • ./includes/modsystem_functions.php
  • ./includes/functions_bigthree.php
  • ./includes/class_postbit.php
  • ./includes/class_bbcode.php
  • ./includes/functions_reputation.php
  • ./includes/functions_post_thanks.php 

Hooks Called:
  • init_startup
  • init_startup_session_setup_start
  • init_startup_session_setup_complete
  • cache_permissions
  • fetch_postinfo_query
  • fetch_postinfo
  • fetch_threadinfo_query
  • fetch_threadinfo
  • fetch_foruminfo
  • style_fetch
  • cache_templates
  • global_start
  • parse_templates
  • global_setup_complete
  • showpost_start
  • bbcode_fetch_tags
  • bbcode_create
  • postbit_factory
  • showpost_post
  • postbit_display_start
  • post_thanks_function_post_thanks_off_start
  • post_thanks_function_post_thanks_off_end
  • post_thanks_function_fetch_thanks_start
  • post_thanks_function_fetch_thanks_end
  • post_thanks_function_thanked_already_start
  • post_thanks_function_thanked_already_end
  • fetch_musername
  • postbit_imicons
  • bbcode_parse_start
  • bbcode_parse_complete_precache
  • bbcode_parse_complete
  • postbit_display_complete
  • post_thanks_function_can_thank_this_post_start
  • showpost_complete