View Single Post
  #309  
Old 04-14-2009, 09:05 PM
cellarius's Avatar
cellarius cellarius is offline
 
Join Date: Aug 2005
Posts: 1,987
Благодарил(а): 0 раз(а)
Поблагодарили: 0 раз(а) в 0 сообщениях
Default

Quote:
Originally Posted by KenDude View Post
If a user uploads a photo titled MyPhoto.JPG into vbgallery, vbg will create a thumbnail called MyPhoto_thumb.jpg by default.
Correct. So far I follow you when trying to reproduce this.

Quote:
However, your code in the pop up window is looking for MyPhoto_thumb.JPG (extension in caps like the original file) and so the user will see red x's instead of thumbnails when they look through their images because Linux treats the file extensions in a case sensitive manner.
Hm, that's where I'm losing you: the code for the thumbnails is genereted by strtolower-ing the file extension, thus it is always lowercase.
Quote:
Now if you click on that red x inserted thumbnail it WILL take you to the correct full size photo because the full size photo does end in .JPG or whatever the all caps extension happened to be.
Actually, the path and filename used to show the thumbnails in the popup window and for the insertion process come from exactly the same variable - they can not be different. Their extensions both have to be lowercase.
By the way: If I'm uploading an image that has a uppercase extension, vBG changes the original uppercase extension to lowercase.


Quote:
This should be as easy as making the _thumb file always end in a lowercase version
That's what the script does at the moment, actually...


Quote:
Thanks in advance for the fix, sorry to keep piling these on you, but my members are a picky bunch and usually find any issues with any code with any browser, etc...
No problem, really. Since I do not use vBG in a productive environment, I don't have the ability to do such intensive testing. This way, sooner or later we'll get it goin'

So, after some more thinking, I decided to take more information directly from the database. All filenames - thumbs, originals, everything including extensions - are now taken directly from the database and thus should mirror exactly what vBG uses. If it works there, it should also work with this mod. Please test the attached config file and see whether it solves the problem. If not, please check whether vBG indeed saves original files with uppercase extensions (which it does not for me - and I was unable to find an option in the vBG settings, tho I did not look too hard) and provide the content of the debug table field for "Code".
Reply With Quote
 
X vBulletin 3.8.12 by vBS Debug Information
  • Page Generation 0.01146 seconds
  • Memory Usage 1,777KB
  • Queries Executed 11 (?)
More Information
Template Usage:
  • (1)SHOWTHREAD_SHOWPOST
  • (1)ad_footer_end
  • (1)ad_footer_start
  • (1)ad_header_end
  • (1)ad_header_logo
  • (1)ad_navbar_below
  • (5)bbcode_quote
  • (1)footer
  • (1)gobutton
  • (1)header
  • (1)headinclude
  • (6)option
  • (1)post_thanks_box
  • (1)post_thanks_button
  • (1)post_thanks_javascript
  • (1)post_thanks_navbar_search
  • (1)post_thanks_postbit_info
  • (1)postbit
  • (1)postbit_onlinestatus
  • (1)postbit_wrapper
  • (1)spacer_close
  • (1)spacer_open 

Phrase Groups Available:
  • global
  • postbit
  • reputationlevel
  • showthread
Included Files:
  • ./showpost.php
  • ./global.php
  • ./includes/init.php
  • ./includes/class_core.php
  • ./includes/config.php
  • ./includes/functions.php
  • ./includes/class_hook.php
  • ./includes/modsystem_functions.php
  • ./includes/functions_bigthree.php
  • ./includes/class_postbit.php
  • ./includes/class_bbcode.php
  • ./includes/functions_reputation.php
  • ./includes/functions_post_thanks.php 

Hooks Called:
  • init_startup
  • init_startup_session_setup_start
  • init_startup_session_setup_complete
  • cache_permissions
  • fetch_postinfo_query
  • fetch_postinfo
  • fetch_threadinfo_query
  • fetch_threadinfo
  • fetch_foruminfo
  • style_fetch
  • cache_templates
  • global_start
  • parse_templates
  • global_setup_complete
  • showpost_start
  • bbcode_fetch_tags
  • bbcode_create
  • postbit_factory
  • showpost_post
  • postbit_display_start
  • post_thanks_function_post_thanks_off_start
  • post_thanks_function_post_thanks_off_end
  • post_thanks_function_fetch_thanks_start
  • post_thanks_function_fetch_thanks_end
  • post_thanks_function_thanked_already_start
  • post_thanks_function_thanked_already_end
  • fetch_musername
  • postbit_imicons
  • bbcode_parse_start
  • bbcode_parse_complete_precache
  • bbcode_parse_complete
  • postbit_display_complete
  • post_thanks_function_can_thank_this_post_start
  • showpost_complete