View Single Post
  #1  
Old 03-26-2009, 12:20 AM
Antivirus's Avatar
Antivirus Antivirus is offline
 
Join Date: Sep 2004
Location: Black Lagoon
Posts: 1,090
Благодарил(а): 0 раз(а)
Поблагодарили: 0 раз(а) в 0 сообщениях
Default Is there a more efficient way to write this code?

I have a plugin I am using in two different locations, however it essentially does the exact same thing for each location with the exception that it pulls data from a different array to set the DM.

PHP Code:
global $sc_typeset;
if (
$sc_typeset == 'sc_typetask' OR $sc_typeset == 'sc_typeevent')
{
    if (
THIS_SCRIPT == 'newthread')
    {
        
$dataman->set('sc_typeset',         $post['sc_typeset']);
        
$dataman->setr('dateline_from',     $post['dateline_from']);
        
$dataman->setr('dateline_to',         $post['dateline_to']);
        
$dataman->setr('sc_description',    $post['sc_description']);
        
$dataman->setr('sc_location',        $post['sc_location']);
    }
    
    if (
THIS_SCRIPT == 'editpost')
    {
        
$dataman->set('sc_typeset',         $edit['sc_typeset']);
        
$dataman->setr('dateline_from',     $edit['dateline_from']);
        
$dataman->setr('dateline_to',         $edit['dateline_to']);
        
$dataman->setr('sc_description',    $edit['sc_description']);
        
$dataman->setr('sc_location',        $edit['sc_location']);
    }
    

As you can see, it's somewhat redundant. I want to include this same plugin code in both hook locations ('newpost_process' & 'editpost_update_process') and simply use a conditional to determine which array to pass to the DM. I was thinking on something like this:
PHP Code:
if (THIS_SCRIPT == 'newthread')
{
    
// use the $newpost array
}
else if (
THIS_SCRIPT == 'editpost')
{
    
// use the $edit array

So basically, what I am asking is if anyone can think of a shorter way to write this than I am currently using?

Thanks!
Reply With Quote
 
X vBulletin 3.8.12 by vBS Debug Information
  • Page Generation 0.01196 seconds
  • Memory Usage 1,788KB
  • Queries Executed 11 (?)
More Information
Template Usage:
  • (1)SHOWTHREAD_SHOWPOST
  • (1)ad_footer_end
  • (1)ad_footer_start
  • (1)ad_header_end
  • (1)ad_header_logo
  • (1)ad_navbar_below
  • (2)bbcode_php
  • (1)footer
  • (1)gobutton
  • (1)header
  • (1)headinclude
  • (6)option
  • (1)post_thanks_box
  • (1)post_thanks_button
  • (1)post_thanks_javascript
  • (1)post_thanks_navbar_search
  • (1)post_thanks_postbit_info
  • (1)postbit
  • (1)postbit_onlinestatus
  • (1)postbit_wrapper
  • (1)spacer_close
  • (1)spacer_open 

Phrase Groups Available:
  • global
  • postbit
  • reputationlevel
  • showthread
Included Files:
  • ./showpost.php
  • ./global.php
  • ./includes/init.php
  • ./includes/class_core.php
  • ./includes/config.php
  • ./includes/functions.php
  • ./includes/class_hook.php
  • ./includes/modsystem_functions.php
  • ./includes/functions_bigthree.php
  • ./includes/class_postbit.php
  • ./includes/class_bbcode.php
  • ./includes/functions_reputation.php
  • ./includes/functions_post_thanks.php 

Hooks Called:
  • init_startup
  • init_startup_session_setup_start
  • init_startup_session_setup_complete
  • cache_permissions
  • fetch_postinfo_query
  • fetch_postinfo
  • fetch_threadinfo_query
  • fetch_threadinfo
  • fetch_foruminfo
  • style_fetch
  • cache_templates
  • global_start
  • parse_templates
  • global_setup_complete
  • showpost_start
  • bbcode_fetch_tags
  • bbcode_create
  • postbit_factory
  • showpost_post
  • postbit_display_start
  • post_thanks_function_post_thanks_off_start
  • post_thanks_function_post_thanks_off_end
  • post_thanks_function_fetch_thanks_start
  • post_thanks_function_fetch_thanks_end
  • post_thanks_function_thanked_already_start
  • post_thanks_function_thanked_already_end
  • fetch_musername
  • postbit_imicons
  • bbcode_parse_start
  • bbcode_parse_complete_precache
  • bbcode_parse_complete
  • postbit_display_complete
  • post_thanks_function_can_thank_this_post_start
  • showpost_complete