Thread: Major Additions - Classifieds
View Single Post
  #193  
Old 03-05-2009, 09:25 AM
pattycake pattycake is offline
 
Join Date: Jan 2009
Posts: 97
Благодарил(а): 0 раз(а)
Поблагодарили: 0 раз(а) в 0 сообщениях
Default

Quote:
Originally Posted by MicroHellas View Post
Max size in Kb or in dimensions?. I'm checking dimensions. Please try to understand something very important on coding. By adding lot's of restrictions, means lots of checks, something that is not so good to performance. Sometimes by using just simple logic is better. By allowing just gif,jpg,png on a max width eg 600, the photo only in a very few situations should be more than 200kb. So why to add one more restriction? I can accept this filesize restriction on audio and video files, but not on photos.

Mary
I can have a 4000x4000 image that is less than 20k.
If I set the limit to 800x600 in the options, this image, although very small in bytes, would not be allowed if I set the limits based on width/height.

The check can be for size in pixels, or the check can be for size in bytes. You chose dimensions - I respect your decision, but I don't necessarily agree with it.

>Please try to understand something very important on coding

Thanks for the coding tip - I pretty much learned that long before I finished my masters degree in computer science.

btw: I had already added the multiple file upload before you released your 1.10 yesterday... I also added the ability to upload in .zip format and.... added additional "pay" options, added a maximum number of active ads per usergroupid option, and... changed the ad listings to show the title, the user, the price, and the expire date in tabular format in the "classifieds_categorieslistingadline" instead of just the title of the ad. Your original code however saved me a ton of work and for that, I definitely thank you.
Reply With Quote
 
X vBulletin 3.8.12 by vBS Debug Information
  • Page Generation 0.01219 seconds
  • Memory Usage 1,766KB
  • Queries Executed 11 (?)
More Information
Template Usage:
  • (1)SHOWTHREAD_SHOWPOST
  • (1)ad_footer_end
  • (1)ad_footer_start
  • (1)ad_header_end
  • (1)ad_header_logo
  • (1)ad_navbar_below
  • (1)bbcode_quote
  • (1)footer
  • (1)gobutton
  • (1)header
  • (1)headinclude
  • (6)option
  • (1)post_thanks_box
  • (1)post_thanks_button
  • (1)post_thanks_javascript
  • (1)post_thanks_navbar_search
  • (1)post_thanks_postbit_info
  • (1)postbit
  • (1)postbit_onlinestatus
  • (1)postbit_wrapper
  • (1)spacer_close
  • (1)spacer_open 

Phrase Groups Available:
  • global
  • postbit
  • reputationlevel
  • showthread
Included Files:
  • ./showpost.php
  • ./global.php
  • ./includes/init.php
  • ./includes/class_core.php
  • ./includes/config.php
  • ./includes/functions.php
  • ./includes/class_hook.php
  • ./includes/modsystem_functions.php
  • ./includes/functions_bigthree.php
  • ./includes/class_postbit.php
  • ./includes/class_bbcode.php
  • ./includes/functions_reputation.php
  • ./includes/functions_post_thanks.php 

Hooks Called:
  • init_startup
  • init_startup_session_setup_start
  • init_startup_session_setup_complete
  • cache_permissions
  • fetch_postinfo_query
  • fetch_postinfo
  • fetch_threadinfo_query
  • fetch_threadinfo
  • fetch_foruminfo
  • style_fetch
  • cache_templates
  • global_start
  • parse_templates
  • global_setup_complete
  • showpost_start
  • bbcode_fetch_tags
  • bbcode_create
  • postbit_factory
  • showpost_post
  • postbit_display_start
  • post_thanks_function_post_thanks_off_start
  • post_thanks_function_post_thanks_off_end
  • post_thanks_function_fetch_thanks_start
  • post_thanks_function_fetch_thanks_end
  • post_thanks_function_thanked_already_start
  • post_thanks_function_thanked_already_end
  • fetch_musername
  • postbit_imicons
  • bbcode_parse_start
  • bbcode_parse_complete_precache
  • bbcode_parse_complete
  • postbit_display_complete
  • post_thanks_function_can_thank_this_post_start
  • showpost_complete