Thread: Mini Mods - Sort Memberlist by Usergroup
View Single Post
  #12  
Old 02-23-2009, 12:48 PM
R-D's Avatar
R-D R-D is offline
 
Join Date: Jan 2008
Posts: 158
Благодарил(а): 0 раз(а)
Поблагодарили: 0 раз(а) в 0 сообщениях
Default

Here's a couple more things you may want to correct before re-uploading the attachment.

Although you clean the groupid variable at the memberlist_start hook, you never use that version, instead you redeclare $groupid later on, using the unclean version.

At memberlist_start
Code:
$groupid = $vbulletin->input->clean_gpc('r', 'groupid', TYPE_UINT);
At memberlist_query_userscount
Code:
if (intval($_REQUEST['groupid']) > 0)
{
	$groupid = intval($_REQUEST['groupid']);
	$condition .= ' AND (FIND_IN_SET(\''.$groupid.'\', membergroupids) OR user.usergroupid = '.$groupid.')';
}

That final part should be:
Code:
if (intval($groupid) > 0)
{
	$condition .= ' AND (FIND_IN_SET(\''.$groupid.'\', membergroupids) OR user.usergroupid = '.$groupid.')';
}


Also, although the $do_not_include variable hides the defined usergroups from the options list, members can still randomly try numbers and pull the memberlist for all those usergroups, regardless of the $do_not_include setting (apart from usergroups that are set in the AdminCP to be hidden from the memberlist).

If you move the $do_not_include declaration to the top of the plugin, it can also be checked when you check if $groupid > 0.
Reply With Quote
 
X vBulletin 3.8.12 by vBS Debug Information
  • Page Generation 0.01177 seconds
  • Memory Usage 1,764KB
  • Queries Executed 11 (?)
More Information
Template Usage:
  • (1)SHOWTHREAD_SHOWPOST
  • (1)ad_footer_end
  • (1)ad_footer_start
  • (1)ad_header_end
  • (1)ad_header_logo
  • (1)ad_navbar_below
  • (3)bbcode_code
  • (1)footer
  • (1)gobutton
  • (1)header
  • (1)headinclude
  • (6)option
  • (1)post_thanks_box
  • (1)post_thanks_button
  • (1)post_thanks_javascript
  • (1)post_thanks_navbar_search
  • (1)post_thanks_postbit_info
  • (1)postbit
  • (1)postbit_onlinestatus
  • (1)postbit_wrapper
  • (1)spacer_close
  • (1)spacer_open 

Phrase Groups Available:
  • global
  • postbit
  • reputationlevel
  • showthread
Included Files:
  • ./showpost.php
  • ./global.php
  • ./includes/init.php
  • ./includes/class_core.php
  • ./includes/config.php
  • ./includes/functions.php
  • ./includes/class_hook.php
  • ./includes/modsystem_functions.php
  • ./includes/functions_bigthree.php
  • ./includes/class_postbit.php
  • ./includes/class_bbcode.php
  • ./includes/functions_reputation.php
  • ./includes/functions_post_thanks.php 

Hooks Called:
  • init_startup
  • init_startup_session_setup_start
  • init_startup_session_setup_complete
  • cache_permissions
  • fetch_postinfo_query
  • fetch_postinfo
  • fetch_threadinfo_query
  • fetch_threadinfo
  • fetch_foruminfo
  • style_fetch
  • cache_templates
  • global_start
  • parse_templates
  • global_setup_complete
  • showpost_start
  • bbcode_fetch_tags
  • bbcode_create
  • postbit_factory
  • showpost_post
  • postbit_display_start
  • post_thanks_function_post_thanks_off_start
  • post_thanks_function_post_thanks_off_end
  • post_thanks_function_fetch_thanks_start
  • post_thanks_function_fetch_thanks_end
  • post_thanks_function_thanked_already_start
  • post_thanks_function_thanked_already_end
  • fetch_musername
  • postbit_imicons
  • bbcode_parse_start
  • bbcode_parse_complete_precache
  • bbcode_parse_complete
  • postbit_display_complete
  • post_thanks_function_can_thank_this_post_start
  • showpost_complete