[Coders Shack]

Originally Posted by buro9

I have a couple of questions.

One relates to the packed/minified javascript. I want to remove the notice that tells people it's a live topic... or re-format it... it's ugly.

So I'm guessing it's written by the javascript, so I would like to see the unpacked JavaScript to adjust it. OR have the additional notice templated in the vBulletin template system.

Next up is security. I got a few errors through:

PHP Code:

Database error in vBulletin 3.8.1:

Invalid SQL:

                                        SELECT COUNT(*) AS count
                                        FROM vb_post AS post
                                        WHERE
                                                (threadid = 14030
                                                AND visible = 1
                                                AND dateline > 1234287978.:
                                                AND userid != 217)
                                                OR (threadid = 14030
                                                AND visible = 1
                                                AND lastedit > 1234286762);

MySQL Error   : You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near ':
                                                AND userid != 217)
                                                OR (threadid = 14030
                                                AND visible = 1
                                ' at line 6 


Now where did that come from?

Checking the php source it seems that you just take the POST'd value and put it straight into the MySql script. Is that correct? If so... BIG ++++ING SECURITY HOLE. Because you've just allowed SQL injection.

Could you confirm whether you really are taking $_POST['value'] and using it directly in the SQL, because you REALLY REALLY need to change that before something very bad happens.

1.06b will be using GPC,

also if you want to change the text for the notice its a phrase, just go to the phrase manager and search by name "livetopic". I will also be managing all the styling by CSS in 1.06b so you can make it look however you want it to.