[cynthetiq]

Originally Posted by Paul M

Yes, it merges the post instantly (like here at vb.org).

It involves changes to the actual plugin code and also vbulletin_quick_reply.js

Thanks! Okay I'm going to read your post more carefully, and ask appropriate questions once I've completely RTFM.

Originally Posted by Voltar

Care to share those improvements?

He has in a post on page 10.

Originally Posted by Paul M

Hmm, well I installed this on my test forum last night, and yes, it has (had) two problems ;

1. The post dateline is not updated on a merge, so it doesn't get seen as unread.

2. The one everyone complains about - no ajax refresh (unless you alter the time stamp, then you get two versions of the same post).


So, since I wanted this on our forum I have fixed both locally - this is what I have done.


1. To fix the timestamp ;

Find ;

PHP Code:

// set info 


Add below it ;

PHP Code:

$dataman2->set('dateline', TIMENOW); 


2. To fix the ajax issue, use this nasty hack ;

Find ;

PHP Code:

    if ($isdoublepost)
    {
        $id = $doublepost['postid'];
        $dataman->save();
 
        //now add edited by
        if ($dp_settings['editedbymsg'] != '')
        {
            $vbulletin->db->query_write("
                REPLACE INTO " . TABLE_PREFIX . "editlog (postid, userid, username, dateline, reason)
                VALUES ($id, " . $vbulletin->userinfo['userid'] . ", '" . addslashes($vbulletin->userinfo['username']) . "', " . TIMENOW . ", '" . addslashes($dp_settings['editedbymsg']) . "')
            ");
        }
    } 


Replace with ;

PHP Code:

    if ($isdoublepost)
    {
        // Ugly hack added by Paul M to fix ajax merge //
        if (!$vbulletin->GPC['ajax'])
        {
            $id = $doublepost['postid'];
            $dataman->save();
 
            if ($dp_settings['editedbymsg'] != '')
            {
                $vbulletin->db->query_write("
                REPLACE INTO " . TABLE_PREFIX . "editlog (postid, userid, username, dateline, reason)
                VALUES ($id, " . $vbulletin->userinfo['userid'] . ", '" . addslashes($vbulletin->userinfo['username']) . "', " . TIMENOW . ", '" . addslashes($dp_settings['editedbymsg']) . "')
                ");
            }
        }
        $vbulletin->url = 'showthread.php?' . $vbulletin->session->vars['sessionurl'] . "p=$post[postid]#post$post[postid]";
        eval(print_standard_redirect('redirect_postthanks', true, false));
    } 


Seems to work okay for me, feel free to try it.

Originally Posted by Leo Brazil

I'm glad to see I'm not the only one on this....lol....I was about say the same thing....lol...

I've seen something similar to this working pretty good on vB.org and I always feel like I really need something like it on my board. But after reading tons of pages I just can't figure out how.

As Xenon seems to be out of this for a long time why not take over it for improvements ?

I believe someone from the community needs to pick it up not the board staff.