Quote:
Originally Posted by CHIPIT
I can confirm I have display errors turned on in php.ini, however an error still occurs when submitting the edited template... as others have said the fix isn't working, though with s810car's modified conditional
PHP Code:
<if condition="(THIS_SCRIPT == 'indexTAB' AND (in_array($forum['forumid'], $GLOBALS[tabcats]) OR in_array('all', $GLOBALS[tabcats]))) OR (THIS_SCRIPT == 'forumdisplay')">
no errors. The parenthesis are what made it work, the quotes around forumid didn't make a difference. The All Forums module still won't display, though that may just be an error on my end since I haven't heard anyone else mention that. |
If you can confirm this works, I will make the change now.
Quote:
Originally Posted by AWJunkies
HERE IS A FIX ENJOY
Step #1
Ok do not or revert whatever patch king posted on his link to his site the trying of passing variable to template which you can not do in this case and circumstances. Basically you should have everything installed how they said to do and the files in zip without changing a thing.
Step #2
Now the correct IF statement to enter is below. So change the if statement they have and where to add it to the below one.
NEW CORRECT IF STATEMENT:
Code:
<if condition="(THIS_SCRIPT == 'indexTAB' AND (in_array($forum['forumid'], $_REQUEST['tabcat']) OR in_array('all', $_REQUEST['tabcat']))) OR (THIS_SCRIPT == 'forumdisplay')">
Step #3
Fix for All forums module: For some reason they put -1 instead of all for the tabcat value. So to fix is real easy. There was no check within IF statement for -1 but there was for all.
Module File info BEFORE:
Code:
tabindex.php?tabcat[]=-1
Module File info AFTER:
Code:
tabindex.php?tabcat[]=all
Step #4
Fix for data arrays within modules must be URL strict not safe.
Example before:
Code:
tabindex.php?tabcat[]=1&amp;tabcat[]=47&amp;tabcat[]=58&amp;tabcat[]=70&amp;tabcat[]=78&amp;langid=1
Example after:
Code:
tabindex.php?tabcat[]=1&tabcat[]=47&tabcat[]=58&tabcat[]=70&tabcat[]=78&langid=1
OPEN:
tfh_modules.php (admincp file)
FIND TWO INSTANCES OF:
Code:
'file' => TYPE_NOHTML,
REPLACE WITH:
Code:
'file' => TYPE_HTML,
Step #5 (OPTIONAL)
Also highly recommended for up to date YUI libraries and much quicker load and single batch calls follow the below instructions. Basically replace the add js code into header that is posted in instructions with the below.
FORUM HOME TEMPLATE CHANGE:
Code:
<!-- Tabbed Forum Home Header Code -->
<!-- Dependencies -->
<!-- TFH Skin CSS for TabView -->
<link rel="stylesheet" type="text/css" href="clientscript/yui/tabview/assets/tabview.css" />
<link rel="stylesheet" type="text/css" href="clientscript/yui/tabview/assets/skin-tfh.css" />
<!-- JavaScript Dependencies for Tabview: -->
<script type="text/javascript" src="clientscript/yui/utilities/utilities.js"></script>
<script type="text/javascript" src="clientscript/yui/element/element-beta-min.js"></script>
<!-- Source file for TabView -->
<script type="text/javascript" src="clientscript/yui/tabview/tabview-min.js"></script>
<!-- Source file for Dispatcher -->
<script type="text/javascript" src="clientscript/yui/tabview/dispatcher.js"></script>
<!-- /Tabbed Forum Home Header Code -->
REPLACE WITH:
Code:
<!-- Tabbed Forum Home Header Code -->
<!-- Dependencies -->
<!-- TFH Skin CSS for TabView -->
<link rel="stylesheet" type="text/css" href="http://yui.yahooapis.com/2.6.0/build/tabview/assets/skins/sam/tabview.css">
<link rel="stylesheet" type="text/css" href="clientscript/yui/tabview/assets/skin-tfh.css" />
<script type="text/javascript" src="http://yui.yahooapis.com/combo?2.6.0/build/utilities/utilities.js&2.6.0/build/element/element-beta-min.js&2.6.0/build/tabview/tabview-min.js"></script>
<!-- Source file for Dispatcher -->
<script type="text/javascript" src="clientscript/yui/tabview/dispatcher.js"></script>
<!-- /Tabbed Forum Home Header Code -->
HERE IS A FIX ENJOY
|
Thanks, after a quick look, they all seem to be correct coding. The 'all' was fixed in the module, but the install codes I wrote before the fix wasn't changed. I am going to make the change now. Upgrade to 2.6.0 for YUI was planned for 2.0.0 Beta 2.
Quote:
Originally Posted by sweetguy2004
but if i remove if statement will this mod will work?
also i want to know which tab vb.org useis it ajax or simple
& it there any tabb mod which is stable have
1- No number of visitors viewing each forum
2- Not crawlable by search engines !
|
vBulletin.org does not use TFH - theirs are custom.
Quote:
Originally Posted by Hugo Holbling
Maybe I'm missing something but is it possible to edit the display order of the tabs? At the moment they are displaying in the order I created them, followed by the enabled modules; ideally "All Forums" would be first and the display orders could be changed.
|
This is a planned feature for beta 2 or 3.
More Information