[ReCom]

Originally Posted by ReCom

Also, the mod seems to mess with the message count and last activity timestamp on social groups listing when both social group messages and social forum are available. Since you give an option to either turn off the group messages or leave them on, you should at least take in consideration cases when a social group has both group messages and forum posts. Message count should be sum of messages and posts and last activity timestamp should take the last message or the last post.

SocialForum 1.4.6
vBulletin 3.7.4 PL1
PHP 5.2.6
MySQL 5.0.51a-community

In reference of my bug report above, I'm tired of waiting so I've fixed it myself. For those forum admins who have both social group messages and social forums (i.e those who didn't disable group messages when installing socialforums), and are bothered with this mod messing the post counts and last post timestamps, here is how to fix it:

Open plugin SocialForums (group_prepareinfo).

Find the following codes:

PHP Code:

            $group['lastpostdate'] = vbdate($vbulletin->options['dateformat'], $getlastpostinfo['lastpost'], true);
            $group['lastposttime'] = vbdate($vbulletin->options['timeformat'], $getlastpostinfo['lastpost']);

             $group['lastposterid'] = "";
             $group['lastposter'] = ""; 


Wrap it in an IF block, resulting in:

PHP Code:

        if ($getlastpostinfo['lastpost'] > $group['lastpost'])
        {
            $group['lastpostdate'] = vbdate($vbulletin->options['dateformat'], $getlastpostinfo['lastpost'], true);
            $group['lastposttime'] = vbdate($vbulletin->options['timeformat'], $getlastpostinfo['lastpost']);

             $group['lastposterid'] = "";
             $group['lastposter'] = "";
        } 


Next find

PHP Code:

            $group['visible'] = $getlastpostinfo['threads'] + $getlastpostinfo['replies']; 


Change it to

PHP Code:

            $group['visible'] += $getlastpostinfo['threads'] + $getlastpostinfo['replies']; 


I sincerely hope for this mod creator to include this fix in the next version.

btw, these two lines in the plugin irritate me:

PHP Code:

         $group['lastposterid'] = "";
             $group['lastposter'] = ""; 


Is it too hard to find out the username of the last poster? My next post in this thread will be a fix for the two lines, if the next version doesn't fix it or it's taking too much time.