Thread: Major Additions - Links and Downloads Manager
View Single Post
  #1441  
Old 10-18-2008, 02:09 AM
AndrewD AndrewD is offline
 
Join Date: Jul 2002
Location: Scotland
Posts: 3,486
Благодарил(а): 0 раз(а)
Поблагодарили: 0 раз(а) в 0 сообщениях
Default

Quote:
Originally Posted by vbboarder View Post
The saved search feature is not working correctly. There's 3 issues:

1. When the search option to find "all words" is selected, it acts the same as "any words." For example, if you put in: mp3 audio, "any words" search would find entries that have either mp3 or audio in its text, "all words" search would find entries that have both mp3 and audio (mp3 & audio do not need to be adjacent) in its text, and "exact phrase" search would find entries that have mp3 audio (mp3 & audio needs to be adjacent to each other) in its text. Well, LDM doesn't do that when "all words" is selected.

2. When I save a search and edit it later, then old settings still remain. For example, I saved a search of "mp3 audio" and selected "exact phrase", then I edited that search to change it to "all words" and marked "update saved search", then I visit the "Saved Searches" link, the search description will read both "exact phrase" and "all words." It might just be a descriptive bug versus a functional bug because when I click on the "mp3 audio" search link, the header states that it's searching "all words" only (though it's searches incorrectly - see bug #1).

3. The saved searches for Profile Searches can not be edited by the user. Though not a functional bug ('cause it works), it results in a logical bug because the search semantics is not correct. For example, if the admin enabled occupation profile searching in LDM settings and the user put in "web developer" in his profile, then when he goes to the LDM Search menu, he gets 2 separate saved searches: "web" and "developer" when it should be "web developer." I think the solution is 2 parts: enable an option to allow profile saved searches to be delimited by commas, and enable the profile saved searches to be edited similar to the self-made saved searches.
I'd noticed the first two problems, and I think I've fixed them in 2.3.0 beta 1. There were bugs particularly in the highlighting code (particularly nasty to fix for languages requiring utf8 character sets) . Thanks.

The third one (profile searches) is a bit more problematic, because, as you say, the feature is working as originally designed. But it's a bit of a fossil and needs rethinking. The inconsistency with other saved searches has only just become apparent, because I only recently made this feature visible - it was there for a couple of years but only to admins.
Reply With Quote
 
X vBulletin 3.8.12 by vBS Debug Information
  • Page Generation 0.01642 seconds
  • Memory Usage 1,769KB
  • Queries Executed 11 (?)
More Information
Template Usage:
  • (1)SHOWTHREAD_SHOWPOST
  • (1)ad_footer_end
  • (1)ad_footer_start
  • (1)ad_header_end
  • (1)ad_header_logo
  • (1)ad_navbar_below
  • (1)bbcode_quote
  • (1)footer
  • (1)gobutton
  • (1)header
  • (1)headinclude
  • (6)option
  • (1)post_thanks_box
  • (1)post_thanks_button
  • (1)post_thanks_javascript
  • (1)post_thanks_navbar_search
  • (1)post_thanks_postbit_info
  • (1)postbit
  • (1)postbit_onlinestatus
  • (1)postbit_wrapper
  • (1)spacer_close
  • (1)spacer_open 

Phrase Groups Available:
  • global
  • postbit
  • reputationlevel
  • showthread
Included Files:
  • ./showpost.php
  • ./global.php
  • ./includes/init.php
  • ./includes/class_core.php
  • ./includes/config.php
  • ./includes/functions.php
  • ./includes/class_hook.php
  • ./includes/modsystem_functions.php
  • ./includes/functions_bigthree.php
  • ./includes/class_postbit.php
  • ./includes/class_bbcode.php
  • ./includes/functions_reputation.php
  • ./includes/functions_post_thanks.php 

Hooks Called:
  • init_startup
  • init_startup_session_setup_start
  • init_startup_session_setup_complete
  • cache_permissions
  • fetch_postinfo_query
  • fetch_postinfo
  • fetch_threadinfo_query
  • fetch_threadinfo
  • fetch_foruminfo
  • style_fetch
  • cache_templates
  • global_start
  • parse_templates
  • global_setup_complete
  • showpost_start
  • bbcode_fetch_tags
  • bbcode_create
  • postbit_factory
  • showpost_post
  • postbit_display_start
  • post_thanks_function_post_thanks_off_start
  • post_thanks_function_post_thanks_off_end
  • post_thanks_function_fetch_thanks_start
  • post_thanks_function_fetch_thanks_end
  • post_thanks_function_thanked_already_start
  • post_thanks_function_thanked_already_end
  • fetch_musername
  • postbit_imicons
  • bbcode_parse_start
  • bbcode_parse_complete_precache
  • bbcode_parse_complete
  • postbit_display_complete
  • post_thanks_function_can_thank_this_post_start
  • showpost_complete