Quote:
Originally Posted by crkgb
In the v3Arcade settings I have it set up so that only the best result counts. it works for all the cases but when the same user gets the same score. Then there are 2 results for the same user listed.
Is there a way to fix this?
|
I fixed it this way, see below.
Note that I don't really take any responsibility for this code. It might be some much better way to do it...
In arcade.php
Find this chunk of code:
PHP Code:
// Time for the scores.
$scores = $db->query_read("SELECT arcade_sessions.*, user.username, user.arcadeoptions" . iif($vbulletin->options['distinctscores'], ", " . iif($game['isreverse']==1, 'MIN', 'MAX') . "(arcade_sessions.score) AS score") . " FROM " . TABLE_PREFIX . "arcade_sessions AS arcade_sessions
LEFT JOIN " . TABLE_PREFIX . "user AS user ON (user.userid=arcade_sessions.userid)
WHERE arcade_sessions.valid=1 AND arcade_sessions.gameid=$game[gameid]
" . iif($vbulletin->options['distinctscores'], "GROUP BY arcade_sessions.userid") . "
ORDER BY score " . iif($game['isreverse']==1, 'ASC', 'DESC') . ", arcade_sessions.finish DESC
LIMIT " . $vbulletin->options['scoresperpage']);
if ($vbulletin->options['distinctscores'])
{
$scorecache = array();
while ($score = $db->fetch_array($scores))
{
$scorecache[] = "(arcade_sessions.score=$score[score] AND arcade_sessions.userid=$score[userid])";
}
$scorecache = implode(' OR ', $scorecache);
$scores = $db->query_read("SELECT arcade_sessions.*, user.username, user.arcadeoptions FROM " . TABLE_PREFIX . "arcade_sessions AS arcade_sessions
LEFT JOIN " . TABLE_PREFIX . "user AS user ON (user.userid=arcade_sessions.userid)
WHERE arcade_sessions.valid=1 AND arcade_sessions.gameid=$game[gameid] AND ($scorecache)
ORDER BY score " . iif($game['isreverse']==1, 'ASC', 'DESC') . ", arcade_sessions.finish DESC
LIMIT " . $vbulletin->options['scoresperpage']);
}
Replace it with this:
PHP Code:
// Time for the scores.
// Replaced code for finding scores, so it won't show duplicates on players with the same score. /SK
$scores = $db->query_read( "SELECT arcade_sessions.*, user.username, user.arcadeoptions FROM " . TABLE_PREFIX . "arcade_sessions AS arcade_sessions
LEFT JOIN " . TABLE_PREFIX . "user AS user ON (user.userid=arcade_sessions.userid)
WHERE arcade_sessions.valid=1 AND arcade_sessions.gameid=$game[gameid]
ORDER BY score " . iif($game['isreverse']==1, 'ASC', 'DESC') . ", arcade_sessions.finish DESC
" . iif( !$vbulletin->options['distinctscores'], "LIMIT " . $vbulletin->options['scoresperpage']) );
if ($vbulletin->options['distinctscores'])
{
$sk_usedusers = array();
$scorecache = array();
while( $score = $db->fetch_array($scores) )
{
if( $sk_usedusers[ $score[userid] ] ) continue;
$sk_usedusers[ $score[userid] ] = true;
$scorecache[] = "arcade_sessions.sessionid=$score[sessionid]";
}
$scorecache = implode(' OR ', $scorecache);
$scores = $db->query_read("SELECT arcade_sessions.*, user.username, user.arcadeoptions FROM " . TABLE_PREFIX . "arcade_sessions AS arcade_sessions
LEFT JOIN " . TABLE_PREFIX . "user AS user ON (user.userid=arcade_sessions.userid)
WHERE arcade_sessions.valid=1 AND arcade_sessions.gameid=$game[gameid] AND ($scorecache)
ORDER BY score " . iif($game['isreverse']==1, 'ASC', 'DESC') . ", arcade_sessions.finish DESC
LIMIT " . $vbulletin->options['scoresperpage']);
}
also find this: (there is some small differences from the code above)
PHP Code:
// Time for the scores.
$scores = $db->query_read("SELECT arcade_sessions.*, user.username" . iif($vbulletin->options['distinctscores'], ", " . iif($game['isreverse']==1, 'MIN', 'MAX') . "(arcade_sessions.score) AS score") . " FROM " . TABLE_PREFIX . "arcade_sessions AS arcade_sessions
LEFT JOIN " . TABLE_PREFIX . "user AS user ON (user.userid=arcade_sessions.userid)
WHERE arcade_sessions.valid=1 AND arcade_sessions.gameid=$game[gameid]
" . iif($vbulletin->options['distinctscores'], "GROUP BY arcade_sessions.userid") . "
ORDER BY score " . iif($game['isreverse']==1, 'ASC', 'DESC') . ", arcade_sessions.finish DESC
LIMIT $start, " . $vbulletin->options['scoresperpage']);
if ($vbulletin->options['distinctscores'])
{
$scorecache = array();
while ($score = $db->fetch_array($scores))
{
$scorecache[] = "(arcade_sessions.score='$score[score]' AND arcade_sessions.userid=$score[userid])";
}
$scorecache = implode(' OR ', $scorecache);
$scores = $db->query_read("SELECT arcade_sessions.*, user.username FROM " . TABLE_PREFIX . "arcade_sessions AS arcade_sessions
LEFT JOIN " . TABLE_PREFIX . "user AS user ON (user.userid=arcade_sessions.userid)
WHERE arcade_sessions.valid=1 AND arcade_sessions.gameid=$game[gameid] " . iif($scorecache, "AND ($scorecache)") . "
ORDER BY score " . iif($game['isreverse']==1, 'ASC', 'DESC') . ", arcade_sessions.finish DESC
LIMIT " . $vbulletin->options['scoresperpage']);
}
Replace it with:
PHP Code:
// Time for the scores.
// Replaced code for finding scores, so it won't show duplicates on players with the same score. /SK
$scores = $db->query_read("SELECT arcade_sessions.*, user.username FROM " . TABLE_PREFIX . "arcade_sessions AS arcade_sessions
LEFT JOIN " . TABLE_PREFIX . "user AS user ON (user.userid=arcade_sessions.userid)
WHERE arcade_sessions.valid=1 AND arcade_sessions.gameid=$game[gameid]
ORDER BY score " . iif($game['isreverse']==1, 'ASC', 'DESC') . ", arcade_sessions.finish DESC
" . iif( !$vbulletin->options['distinctscores'], " LIMIT $start, " . $vbulletin->options['scoresperpage']) );
if ($vbulletin->options['distinctscores'])
{
$sk_usedusers = array();
$scorecache = array();
while( $score = $db->fetch_array($scores) )
{
if( $sk_usedusers[ $score[userid] ] ) continue;
$sk_usedusers[ $score[userid] ] = true;
$scorecache[] = "arcade_sessions.sessionid=$score[sessionid]";
}
$scorecache = implode(' OR ', $scorecache);
$scores = $db->query_read("SELECT arcade_sessions.userid, arcade_sessions.*, user.username FROM " . TABLE_PREFIX . "arcade_sessions AS arcade_sessions
LEFT JOIN " . TABLE_PREFIX . "user AS user ON (user.userid=arcade_sessions.userid)
WHERE arcade_sessions.valid=1 AND arcade_sessions.gameid=$game[gameid] " . iif($scorecache, "AND ($scorecache)") . "
ORDER BY score " . iif($game['isreverse']==1, 'ASC', 'DESC') . ", arcade_sessions.finish DESC
LIMIT $start, " . $vbulletin->options['scoresperpage']);
}
/SK
More Information