Thread: New Posting Features - Append User Agent String to New Threads and Posts
View Single Post
  #29  
Old 10-13-2008, 12:08 AM
dartho dartho is offline
 
Join Date: Sep 2005
Location: Australia
Posts: 2,303
Благодарил(а): 0 раз(а)
Поблагодарили: 0 раз(а) в 0 сообщениях
Default

I've had another look and the *may* be missing parenthesis in a plugin - I say may as I think it should be OK anyway, but if you could edit the Add Useragent String to New Posts and Add Useragent String to New Threads plugins and change
Code:
if ((($vbulletin->options['ua37_enabled']) && ($_POST[preview] != "Preview Post")  && (!in_array($styleid,explode(",",$vbulletin->options['ua37_not_this_style'])))) && (in_array($threadinfo[forumid],explode(",",$vbulletin->options['ua37_this_forum_only'])) || (trim($vbulletin->options['ua37_this_forum_only'])=="")))
to

Code:
if ((($vbulletin->options['ua37_enabled']) && ($_POST[preview] != "Preview Post")  && (!in_array($styleid,explode(",",$vbulletin->options['ua37_not_this_style'])))) && ((in_array($threadinfo[forumid],explode(",",$vbulletin->options['ua37_this_forum_only']))) || (trim($vbulletin->options['ua37_this_forum_only'])=="")))
and see if that fixes things?

-----

For a reality check - the logic for adding the useragent string is as follow:

IF the product is enabled, AND we are not previewing the post AND the user is not using an excluded style are all true

AND

We are in an forum where UA strings should be appended OR no forums are specified (ie. append in all forums) are true

THEN add the UA string

this sound right?
Reply With Quote
 
X vBulletin 3.8.12 by vBS Debug Information
  • Page Generation 0.01179 seconds
  • Memory Usage 1,765KB
  • Queries Executed 11 (?)
More Information
Template Usage:
  • (1)SHOWTHREAD_SHOWPOST
  • (1)ad_footer_end
  • (1)ad_footer_start
  • (1)ad_header_end
  • (1)ad_header_logo
  • (1)ad_navbar_below
  • (2)bbcode_code
  • (1)footer
  • (1)gobutton
  • (1)header
  • (1)headinclude
  • (6)option
  • (1)post_thanks_box
  • (1)post_thanks_button
  • (1)post_thanks_javascript
  • (1)post_thanks_navbar_search
  • (1)post_thanks_postbit_info
  • (1)postbit
  • (1)postbit_onlinestatus
  • (1)postbit_wrapper
  • (1)spacer_close
  • (1)spacer_open 

Phrase Groups Available:
  • global
  • postbit
  • reputationlevel
  • showthread
Included Files:
  • ./showpost.php
  • ./global.php
  • ./includes/init.php
  • ./includes/class_core.php
  • ./includes/config.php
  • ./includes/functions.php
  • ./includes/class_hook.php
  • ./includes/modsystem_functions.php
  • ./includes/functions_bigthree.php
  • ./includes/class_postbit.php
  • ./includes/class_bbcode.php
  • ./includes/functions_reputation.php
  • ./includes/functions_post_thanks.php 

Hooks Called:
  • init_startup
  • init_startup_session_setup_start
  • init_startup_session_setup_complete
  • cache_permissions
  • fetch_postinfo_query
  • fetch_postinfo
  • fetch_threadinfo_query
  • fetch_threadinfo
  • fetch_foruminfo
  • style_fetch
  • cache_templates
  • global_start
  • parse_templates
  • global_setup_complete
  • showpost_start
  • bbcode_fetch_tags
  • bbcode_create
  • postbit_factory
  • showpost_post
  • postbit_display_start
  • post_thanks_function_post_thanks_off_start
  • post_thanks_function_post_thanks_off_end
  • post_thanks_function_fetch_thanks_start
  • post_thanks_function_fetch_thanks_end
  • post_thanks_function_thanked_already_start
  • post_thanks_function_thanked_already_end
  • fetch_musername
  • postbit_imicons
  • bbcode_parse_start
  • bbcode_parse_complete_precache
  • bbcode_parse_complete
  • postbit_display_complete
  • post_thanks_function_can_thank_this_post_start
  • showpost_complete