[tommythejoat]

I looked over the code and it looks fine to me. There is one nuance that is not really important. When you are using intval to parse a number from a string, you don't need to snip off the number, you just need to start at the right place and intval will stop converting when it finds a non-numeric character.

While we are discussing this, I decided I needed to move the importid's into their own table and built this table:

CREATE TABLE `importedid` (
`idtype` VARCHAR( 25 ) NOT NULL,
`oldid` INT UNSIGNED NOT NULL,
`newid` INT UNSIGNED NOT NULL,
PRIMARY KEY (`idtype`, `oldid`)
) TYPE = MYISAM;

I then populated the table from the importids of each of the imported tables assigning the values post, thread, forum, attachment and user to the idtype field. Here is an example of one of the queries I used to do this.

INSERT INTO `importedid` (`idtype`, `oldid`, `newid`)
SELECT "attach", `importattachmentid`, `attachmentid`
FROM `attachment` WHERE `importattachmentid`>0

The sql that I am trying to use to query this table is:

PHP Code:

        if (strpos($_SERVER['REQUEST_URI'], "/{$old_folder}{$old_thread_script}") === 0)
        {
            $action = 'thread';
            $old_id = intval(substr($_SERVER['REQUEST_URI'], strpos($_SERVER['REQUEST_URI'], ';gtid=')+6)); //to the end of the string
            if (strpos($_SERVER['REQUEST_URI'], ';pagenumber='))
            {
                $page = intval(substr($_SERVER['REQUEST_URI'], strpos($_SERVER['REQUEST_URI'], ';pagenumber=')+12));
            }
            $sql = "SELECT newid FROM {$tableprefix}importedid WHERE oldid={$old_id} AND idtype = {$action}"; 


When I copy this up and enter a url for the old board in my browser, it fails to find the new id. The result is the code 10 id not found no matter what I enter. I am guessing there is something wrong with the $sql, but I cannot figure out what it might be. I would appreciate any advice. I can't see why this doesn't work and maybe I am just too close to it. The board is live now and I don't want to take it down to play with this.

The older version that takes the id's out of the various importid's in the tables works just fine. I put it back each time I try to fix the above with a new idea and the new idea does not work.