[tk102]

Just installed. Good job, it was just what I was looking for.


Three things:

1) It'd be nice to have the recipient usergroups to be specified on a forum-by-forum basis rather than a single set of groups. Haven't looked at what this would require though.

2) I noticed that for members that have already registered, their new userfield value in the userfield table shows up as NULL rather than Yes or No, which is deceptive since it appears to be Yes in the User Options area of the UCP. There's plenty of workarounds to this including simply reversing the "Yes / No" options to "No / Yes" when creating the userfield during installation. This would cause the No to show up in the UCP by default which has the same behavior here as NULL.

3) I noticed that your "AutoPM Save Thread Info" hook only looks for users who have the recipient usergroup as their primary usergroup. I added the following to the code to search for users who have the recipient group as a secondary group (though there's probably a more efficient means to do this):

After this:

		while ($name = $vbulletin->db->fetch_array($usernames))
		{
			$pm2users[] = $name['username'];
		}
		
		$vbulletin->db->free_result($usernames);

Insert this:

                $autopm_groups=explode(',',$vbulletin->options['sendpm_usergroups']);
                while ($autopm_group = array_shift($autopm_groups)) {
                    $usernames = $vbulletin->db->query_read("
                            SELECT username
                            FROM " . TABLE_PREFIX . "user
                            LEFT JOIN " . TABLE_PREFIX . "userfield AS userfield ON (user.userid = userfield.userid)
                            WHERE membergroupids REGEXP '(^|,| )".trim($autopm_group)."($|,| )'
                            AND field" . $vbulletin->options['sendpm_sendme'] . " = 'Yes'
                            ORDER BY username ASC
                    "); 
                    while ($name = $vbulletin->db->fetch_array($usernames))
                    {
			$pm2users[] = $name['username'];
                    }
                    $vbulletin->db->free_result($usernames);   
                }

Thanks for the mod!