Thread: Major Additions - Links and Downloads Manager
View Single Post
  #841  
Old 08-15-2008, 11:14 AM
AndrewD AndrewD is offline
 
Join Date: Jul 2002
Location: Scotland
Posts: 3,486
Благодарил(а): 0 раз(а)
Поблагодарили: 0 раз(а) в 0 сообщениях
Default

Quote:
Originally Posted by derfelix View Post
While we are at it.. a little internetexplorer bug when editing keywords..

ok we are at the normal display page.. with a page with 20 entries..
each entry (depending of the template you are using) allows you as admin to edit keywords inline..

works fine (I modified the template a little bit)
BUT if you toggle the tag graphic the word "keywords" appears and a field where you can edit the keywords of this entry.. and a go button..

if you click the word "keywords" it goes back to the tag symbol...

In IE7 it acts weird.. because the link is linked to a jumpmark that doesnt really exist.. #$linkid
and it eventually reloads the page.. or pushes the link to the top of the screen when you edit it.. (adding the jumpmark #$linkid to the url)

I fixed it that way:
the link in the template is:
HTML Code:
<a href="#{$linkid}" onclick="ldm_show('keys{$linkid}_', 1, 2);">$vbphrase[ll_keywords]</a>
i changed it to:
HTML Code:
<a href="#" onclick="ldm_show('keys{$linkid}_', 1, 2);return false;">$vbphrase[ll_keywords]</a>
It has to be done twice (also for the tag image when you toggle).. otherwise IE will jump to the link.. this is NOT the way it should act (imho).. because:

if you are editing the last link on the page... it will open the editfield (as it should) but will then "jump" to that link.. so if you had it in the middle of the page.. it will scroll that link to the top of the page..
It's the same when you close the editbox when klicking on the word: "keywords"
(grrr hope you understood what i meant)


Anyway there should at least be a: return false; at the end of the "onclick" stuff..

Felix

PS: I also removed the $linkid leaving only the # thinking there is no point jumping to that link because you are allready at that link..(i might be wrong)
I can't reproduce this, but I can see what you saying and have coded the change (also got rid of some duplicate text that I'd put in there for debugging quite a while ago and forgot about...)
Reply With Quote
 
X vBulletin 3.8.12 by vBS Debug Information
  • Page Generation 0.01203 seconds
  • Memory Usage 1,774KB
  • Queries Executed 11 (?)
More Information
Template Usage:
  • (1)SHOWTHREAD_SHOWPOST
  • (1)ad_footer_end
  • (1)ad_footer_start
  • (1)ad_header_end
  • (1)ad_header_logo
  • (1)ad_navbar_below
  • (2)bbcode_html
  • (1)bbcode_quote
  • (1)footer
  • (1)gobutton
  • (1)header
  • (1)headinclude
  • (6)option
  • (1)post_thanks_box
  • (1)post_thanks_button
  • (1)post_thanks_javascript
  • (1)post_thanks_navbar_search
  • (1)post_thanks_postbit_info
  • (1)postbit
  • (1)postbit_onlinestatus
  • (1)postbit_wrapper
  • (1)spacer_close
  • (1)spacer_open 

Phrase Groups Available:
  • global
  • postbit
  • reputationlevel
  • showthread
Included Files:
  • ./showpost.php
  • ./global.php
  • ./includes/init.php
  • ./includes/class_core.php
  • ./includes/config.php
  • ./includes/functions.php
  • ./includes/class_hook.php
  • ./includes/modsystem_functions.php
  • ./includes/functions_bigthree.php
  • ./includes/class_postbit.php
  • ./includes/class_bbcode.php
  • ./includes/functions_reputation.php
  • ./includes/functions_post_thanks.php 

Hooks Called:
  • init_startup
  • init_startup_session_setup_start
  • init_startup_session_setup_complete
  • cache_permissions
  • fetch_postinfo_query
  • fetch_postinfo
  • fetch_threadinfo_query
  • fetch_threadinfo
  • fetch_foruminfo
  • style_fetch
  • cache_templates
  • global_start
  • parse_templates
  • global_setup_complete
  • showpost_start
  • bbcode_fetch_tags
  • bbcode_create
  • postbit_factory
  • showpost_post
  • postbit_display_start
  • post_thanks_function_post_thanks_off_start
  • post_thanks_function_post_thanks_off_end
  • post_thanks_function_fetch_thanks_start
  • post_thanks_function_fetch_thanks_end
  • post_thanks_function_thanked_already_start
  • post_thanks_function_thanked_already_end
  • fetch_musername
  • postbit_imicons
  • bbcode_parse_start
  • bbcode_parse_complete_precache
  • bbcode_parse_complete
  • postbit_display_complete
  • post_thanks_function_can_thank_this_post_start
  • showpost_complete