[IrPr]

Originally Posted by derfelix

@obmob
yes thats when you add or modify.. but if you are in a category just browsing the links, i have (top left) a dropdown "sort by" and just below that a second dropdown called "filter".. thats the one i meant.
----------
@Andrew..
just found a little (for me) bug in ratings...
If 3 people rate a link.. lets say:
user 1 rates 5
user 2 rates 3
user 3 rates 4
(total 12 => average 4 ... works fine)

now 2 things can happen:
1. another user comments.. but does NOT rate..
2. user 3 clicks on "Clear ratings"

in my understanding the average should still be 4.. because only 2 users have rated.. (users 1 and 2 .. total 8.. average 4)

But its different.. if 1. happens.. rating becomes 8/3 => ~3
if 2. happens rating becomes 12/4 => 3
and if 1. AND 2 happen.. then rating becomes 8/4 => 2!

Maybe its supposed to be like that..but
Personally i dont want users that have commented but NOT rated to be counted in ratings..
so i made myself a little fix:

open: local_links_actions.php
in function ldm_fix_rating_counts find:

PHP Code:

    foreach ($rates as $r) {
        $numrate += 1;
        $totrate += $r;
    } 


replace with

PHP Code:

    foreach ($rates as $r) {
        if($r>0)
        {
            $numrate += 1;
            $totrate += $r;
        }
    } 


of course on live sites this will not be an ideal solution.. because it will only fix the rating of a link as soon as somebody either rates or comments..
if the site is still small.. admin can modify (open and save) 1 comment/rating in each existing link.. .. if a link is commented/rated for the first time.. there is no problem..

[EDIT] AHHHHHHH... drawback.. now the the number of comments (as it is the same number will only show the amount of ratings.. (not counting the number of comments that have no vote) [/EDIT]
...

-------------
A yes another harder to fix issue..
in the dropdown where you preview the comments (in the linkbit).. IF the site is running in UTF-8 there are some issues (strange characters appearing) sometimes..
I found the problem..
its in the function ldm_cleantext_to_width_rows
IF you run UTF8 and have a special character where the line is supposed to stop.. substr can truncate a non ascii character.. because the count is wrong.. returning the string but the last character is truncated.. showing a weird sign..
The only fix I know of is to use mb_strlen and mb_substr instead of strlen and substr..
I did some test by replacing substr(....) by mb_substr(.....,"UTF-8") in that function.. (also the strlen)
IT WORKS for me.. BUT..
if the mb_substr exists since php 4.06 not all providers have the php multi-byte extension installed.. (i had to activate them on my localhost)
so a fix would only be for those who have it installed.. and are using UTF-8 .. but it still is a a pain.. because you have to specify the encoding every time... AND you DONT always need the mb_substr.. only sometimes.. like here.
maybe there is another workaround???

Felix





..

Awesome!
thanks Felix