What I've done is make the instructions as simple as possible for users with less experience to be able to use this as a starting point for other things and can easily edit/remove later. Admins with more coding experience can put the contents where it is more suited, as I have with a number of modifications here on vB.org.
There is no such thing as a "no no" here. It works, and they can fix it as they become more knowledgeable. That is, if they come to even care about such things. Knowledge of validation and the like come later, as you learn more. You don't slam people with it all at once for a perceived sense of etiquette that doesn't exist. People who know better, can adjust it themselves, with little to no effort.
The javascript of a great many mods here on this site are not in the clientscript folder for one very good reason. In case they want to remove it or replace it, they can easily find it. There's no reason I should have to put the javascript anywhere specific, for functionality or validation reasons.
If you wanted to make a suggestion, that's one thing. But the way you've phrased it is more reproving then instructive, with the spirit more inclined to engender confrontation then edification.
|