You would be correct.
Much of it was hard coded and copy-pasted from the original hack.
I have been slowly re-writing the entire thing though, it's just taking longer than i have anticipated. Much of it is due to handling the amount of information (over 130 individual stat items) returned from the wowarmory.com's character XML file and finding an easily customizable way to display that information on a per class, or even talent spec, basis.
For what you want to do though (Multiple servers + characters per postbit) , I won't include features like that because it would be impossible to write code to support the many ways you would be able to get that information to the hook.
I would instead have methods/functions available (such as GetCharacterURL($server,$char,$locale) that you would call in your own hook with your own processing of the custom profile field.
so for example, you would have a profile field that people would enter character/realm info like
US|Vek'nilash|Azaril
US|Vek'nilash|Offended
US|Uldaman|Azaril
and your code in the postbit_start hook would look like
PHP Code:
// process profile field.
$postbit_array = split("\n", $post[field6] );
foreach($postbit_array as $line)
{
$line_array = split("|",$line);
list($locale, $realm, $char) = $line_array;
$URL .= GetCharacterURL($char,$realm,$locale) . "\n";
}
// replace hook in postbit cache
$find = '$postbit_left';
$replace = $URL;
$template = $template_cache['postbit'];
$template = str_replace($find, $replace, $template);
Of course that's all pseudo code and you'll have to write it accordingly, but that's the general idea of what would need to be done.