View Single Post
  #209  
Old 06-19-2008, 05:36 AM
Michael Biddle Michael Biddle is offline
 
Join Date: Apr 2004
Location: Anaheim, CA
Posts: 774
Благодарил(а): 0 раз(а)
Поблагодарили: 0 раз(а) в 0 сообщениях
Default

Not sure if this has been reported, but you have a real problem in this. The $candecimate variable will not show up if you have a zero (0) value set for the maximum posts. Also after that fixed I realized that if it was at zero, it would throw an error from decimator.php. Both of my fixes are tested on 3.6.8.

I had to change the plugin to this:

PHP Code:
global $candecimate$vbulletin;
if(
$vbulletin->options['sd_enabled'])
{
    
$candecimate false;
    
$modgroups explode(","$vbulletin->options['modgroupid']);
    
$supergroups explode(","$vbulletin->options['supermodid']);
    
$admingroups explode(","$vbulletin->options['adminid']);
    
$decimators array_merge($admingroups,$modgroups,$supergroups);
    
    if(!
in_array($post['usergroupid'], $decimators))
    {
          if(
in_array($vbulletin->userinfo['usergroupid'], $decimators))
          {
            if(
$vbulletin->options['sd_postmax'] == '0')
            {
                
$candecimate true;
            }
            else
            {
                if(
$post['posts'] < $vbulletin->options['sd_postmax'])
                {
                    
$candecimate true;
                }
            }
          }
    }
}
else
{
    
$candecimate false;

and then in decimator.php find this:

PHP Code:
if($spammerinfo['posts'] > $vbulletin->options['sd_postmax'])
            {
                
$error "Spammer has more than " $vbulletin->options['sd_postmax'] .
                         
" posts and cannot be decimated!";
            } 
and change to this:

PHP Code:
if($vbulletin->options['sd_postmax'] > '0')
        {
            if(
$spammerinfo['posts'] > $vbulletin->options['sd_postmax'])
            {
                
$error "Spammer has more than " $vbulletin->options['sd_postmax'] .
                         
" posts and cannot be decimated!";
            }
        } 
Hope this helps others.
Reply With Quote
 
X vBulletin 3.8.12 by vBS Debug Information
  • Page Generation 0.01125 seconds
  • Memory Usage 1,791KB
  • Queries Executed 11 (?)
More Information
Template Usage:
  • (1)SHOWTHREAD_SHOWPOST
  • (1)ad_footer_end
  • (1)ad_footer_start
  • (1)ad_header_end
  • (1)ad_header_logo
  • (1)ad_navbar_below
  • (3)bbcode_php
  • (1)footer
  • (1)gobutton
  • (1)header
  • (1)headinclude
  • (6)option
  • (1)post_thanks_box
  • (1)post_thanks_button
  • (1)post_thanks_javascript
  • (1)post_thanks_navbar_search
  • (1)post_thanks_postbit_info
  • (1)postbit
  • (1)postbit_onlinestatus
  • (1)postbit_wrapper
  • (1)spacer_close
  • (1)spacer_open 

Phrase Groups Available:
  • global
  • postbit
  • reputationlevel
  • showthread
Included Files:
  • ./showpost.php
  • ./global.php
  • ./includes/init.php
  • ./includes/class_core.php
  • ./includes/config.php
  • ./includes/functions.php
  • ./includes/class_hook.php
  • ./includes/modsystem_functions.php
  • ./includes/functions_bigthree.php
  • ./includes/class_postbit.php
  • ./includes/class_bbcode.php
  • ./includes/functions_reputation.php
  • ./includes/functions_post_thanks.php 

Hooks Called:
  • init_startup
  • init_startup_session_setup_start
  • init_startup_session_setup_complete
  • cache_permissions
  • fetch_postinfo_query
  • fetch_postinfo
  • fetch_threadinfo_query
  • fetch_threadinfo
  • fetch_foruminfo
  • style_fetch
  • cache_templates
  • global_start
  • parse_templates
  • global_setup_complete
  • showpost_start
  • bbcode_fetch_tags
  • bbcode_create
  • postbit_factory
  • showpost_post
  • postbit_display_start
  • post_thanks_function_post_thanks_off_start
  • post_thanks_function_post_thanks_off_end
  • post_thanks_function_fetch_thanks_start
  • post_thanks_function_fetch_thanks_end
  • post_thanks_function_thanked_already_start
  • post_thanks_function_thanked_already_end
  • fetch_musername
  • postbit_imicons
  • bbcode_parse_start
  • bbcode_parse_complete_precache
  • bbcode_parse_complete
  • postbit_display_complete
  • post_thanks_function_can_thank_this_post_start
  • showpost_complete